From: Keith Busch <keith.busch@linux.intel.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Keith Busch <keith.busch@intel.com>,
Christoph Hellwig <hch@lst.de>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH] nvme: trace: add disk name to tracepoints
Date: Thu, 28 Jun 2018 09:02:18 -0600 [thread overview]
Message-ID: <20180628150218.GA12970@localhost.localdomain> (raw)
In-Reply-To: <c25e48f5-ace4-5d2c-8174-11ac63316323@grimberg.me>
On Thu, Jun 28, 2018 at 05:34:07PM +0300, Sagi Grimberg wrote:
>
> > Thinking more on this, not using the hw qid really limits the utility
> > out of using these trace events: We may not be able to match a completion
> > to the submission without it since cmdid alone isn't enough to match up
> > the two events.
> >
> > Here's an updated proposal and actually tested. I was also able to
> > combine admin and io submissions.
>
> This looks good!
>
> One thing that is missing is the controller id when we have multiple
> controllers/subsystems in the host like:
>
> TP_printk("nvme%d: qid=%d, nsid=%u, cmdid=%u, flags=0x%x, meta=0x%llx,
> cmd=(%s %s)",
>
> But Johannes can add it I guess.
Yep, I'm sort of going off on a tangent from what Johannes was adding.
We definitely need both. I have some time today, I'll send out the a
series with the combined results.
next prev parent reply other threads:[~2018-06-27 19:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-26 13:51 [PATCH v4 0/2] nvme: add controller id and disk name to tracepoints Johannes Thumshirn
2018-06-26 13:51 ` [PATCH v4 1/2] nvme: cache struct nvme_ctrl reference to struct nvme_request Johannes Thumshirn
2018-06-26 14:55 ` Keith Busch
2018-06-27 7:35 ` Johannes Thumshirn
2018-06-27 8:45 ` Sagi Grimberg
2018-06-26 13:51 ` [PATCH] nvme: trace: add disk name to tracepoints Johannes Thumshirn
2018-06-26 15:01 ` Keith Busch
2018-06-27 7:33 ` Johannes Thumshirn
2018-06-27 8:06 ` Sagi Grimberg
2018-06-27 10:00 ` Johannes Thumshirn
2018-06-27 23:43 ` Keith Busch
2018-06-28 0:59 ` Keith Busch
2018-06-28 7:44 ` Johannes Thumshirn
2018-06-28 14:34 ` Sagi Grimberg
2018-06-28 15:02 ` Keith Busch [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-30 13:20 Johannes Thumshirn
2018-05-30 23:06 ` Sagi Grimberg
2018-05-31 16:47 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628150218.GA12970@localhost.localdomain \
--to=keith.busch@linux.intel.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox