From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 4/4] nvme: add disk name to tracepoints
Date: Fri, 29 Jun 2018 10:00:08 +0200 [thread overview]
Message-ID: <20180629080008.GB13413@lst.de> (raw)
In-Reply-To: <20180628214956.13877-5-keith.busch@intel.com>
> +const char *nvme_trace_disk_name(struct trace_seq *p, char *name)
> +{
> + const char *ret = trace_seq_buffer_ptr(p);
> +
> + if (name[0] != 0)
> + trace_seq_printf(p, "disk=%-.*s, ", DISK_NAME_LEN, name);
if (*name)
trace_seq_printf(p, "disk=%-.*s, ", DISK_NAME_LEN, name);
?
> + req->rq_disk ?
> + memcpy(__entry->disk, req->rq_disk->disk_name, DISK_NAME_LEN) :
> + memset(__entry->disk, 0, DISK_NAME_LEN);
Make this a helper please.
prev parent reply other threads:[~2018-06-29 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 21:49 [PATCHv2 0/4] nvme trace updates Keith Busch
2018-06-28 21:49 ` [PATCHv2 1/4] nvme: trace nvme queue identifiers Keith Busch
2018-06-29 7:24 ` Johannes Thumshirn
2018-06-29 7:57 ` Christoph Hellwig
2018-06-28 21:49 ` [PATCHv2 2/4] nvme: cache struct nvme_ctrl reference to struct nvme_request Keith Busch
2018-06-29 7:25 ` Johannes Thumshirn
2018-06-28 21:49 ` [PATCHv2 3/4] nvme: trace controller name Keith Busch
2018-06-29 7:25 ` Johannes Thumshirn
2018-06-28 21:49 ` [PATCHv2 4/4] nvme: add disk name to tracepoints Keith Busch
2018-06-29 7:27 ` Johannes Thumshirn
2018-06-29 8:00 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629080008.GB13413@lst.de \
--to=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox