From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61078C6778C for ; Fri, 29 Jun 2018 17:43:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D5FC20846 for ; Fri, 29 Jun 2018 17:43:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D5FC20846 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934395AbeF2Rnh (ORCPT ); Fri, 29 Jun 2018 13:43:37 -0400 Received: from mga14.intel.com ([192.55.52.115]:17882 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932999AbeF2Rnf (ORCPT ); Fri, 29 Jun 2018 13:43:35 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jun 2018 10:43:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,286,1526367600"; d="scan'208";a="62670827" Received: from shivamur-mobl.gar.corp.intel.com (HELO localhost) ([10.249.254.20]) by fmsmga002.fm.intel.com with ESMTP; 29 Jun 2018 10:43:30 -0700 Date: Fri, 29 Jun 2018 20:43:28 +0300 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Peter Huewe , Arnd Bergmann , Greg Kroah-Hartman , "Winkler, Tomas" , Azhar Shaikh , Stefan Berger , open list Subject: Re: [PATCH] tpm: require to compile as part of the kernel Message-ID: <20180629174328.GA4060@linux.intel.com> References: <20180629151005.10899-1-jarkko.sakkinen@linux.intel.com> <20180629153141.GE379@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180629153141.GE379@ziepe.ca> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 29, 2018 at 09:31:41AM -0600, Jason Gunthorpe wrote: > On Fri, Jun 29, 2018 at 06:10:02PM +0300, Jarkko Sakkinen wrote: > > Do not allow to compile TPM core as a module. TPM defines a root of > > trust for integrity and keyring subsystems and should be always > > available and not be loaded from the user space. There is no a > > reasonable use case for a loadable module existing. > > > > Signed-off-by: Jarkko Sakkinen > > --- > > drivers/char/tpm/Kconfig | 2 +- > > include/linux/tpm.h | 3 +-- > > 2 files changed, 2 insertions(+), 3 deletions(-) > > This doesn't really make sense.. > > The kconfig method is that if IMA requires TPM it should declare so > and TPM will become non-modular because IMA is non-modular. > > There are lots of legitimate use cases for TPM that don't involve IMA > or keyring. In what context would it make sense to have TPM core as a module? I forgot to add RFC tag this patch. Did not meant to push it to mainline but more to rise up the discussion. /Jarkko