From: John Whitmore <johnfwhitmore@gmail.com>
To: devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
pombredanne@nexb.com, kstewart@linuxfoundation.org,
gregkh@linuxfoundation.org
Subject: staging: rtl8192u: RFC - harmonisation of rtl819x_HT.h ?
Date: Fri, 29 Jun 2018 19:10:04 +0100 [thread overview]
Message-ID: <20180629181007.18071-1-johnfwhitmore@gmail.com> (raw)
This patch set includes two fairly trivial patches but the third patch is
possibly controversial.
There are two files called rtl819x_HT.h
$ find -name rtl819x_HT.h -print
./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
./drivers/staging/rtl8192e/rtl819x_HT.h
The two files are very similar but the rtl8192u file includes more, and I think
unused, definitions definitions. My, possibly flawed, thinking is that it
might be easier to maintain a single file if the two could be merged into a
single include file.
As a first step towards this my third patch comments out unused
definitions, from ./drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
At this point I have compiled all c files under ./drivers/staging/rtl8192u and
all still compile. I may well have missed something, but I assume that no
source file outside that sub tree should be including header files from that
subtree.
next reply other threads:[~2018-06-29 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 18:10 John Whitmore [this message]
2018-06-29 18:10 ` [PATCH 1/3] staging: rtl8192u: Use __func__ instead of hardcoded string - Style John Whitmore
2018-07-02 8:41 ` Greg KH
[not found] ` <CAA_1HzEkZZmE1skOs=mLNFfKf9aBnR_bunddh_fcYX=RhcprzA@mail.gmail.com>
2018-07-02 9:14 ` Greg KH
2018-06-29 18:10 ` [PATCH 2/3] staging: rtl8192u Remove redundant #include directive John Whitmore
2018-06-29 18:10 ` [PATCH 3/3] staging: rtl8192u: Prune the rtl819x_HT.h file of unused definitions John Whitmore
2018-06-30 8:34 ` Justin Skists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629181007.18071-1-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox