From: Keith Busch <keith.busch@intel.com>
To: Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Keith Busch <keith.busch@intel.com>
Subject: [PATCHv3 0/4] nvme trace updates
Date: Fri, 29 Jun 2018 13:59:56 -0600 [thread overview]
Message-ID: <20180629200000.16171-1-keith.busch@intel.com> (raw)
This patch series is based on/inspired by Johannes Thumshirn that
improves the nvme trace events.
The first one from Sagi is saving the nvme_ctrl in the driver request data
so we can reference it in other places, both for this series and future
developments.
The others are adding and simplifying the nvme traces so we can see
information to uniquely identify what hardware the trace event is showing,
and filter events for specific hardware.
v2 -> v3:
Removed unrelated code that leaked into the previous series
Added helpers for setting the qid and disk name fields
Simplified printing the disk name: it's already null terminated, so
don't need to define the limit.
Updated change logs
Minor code formatting updates
Added Reviewed-by for Sagi's patch
v1 -> v2:
Dropped the blk-mq patch as there were pre-existing ways to get to the
desired information without introducing a new API
Changelog typo fixups
Keith Busch (3):
nvme: use hw qid in trace events
nvme: add controller name to trace events
nvme: add disk name to trace events
Sagi Grimberg (1):
nvme: cache struct nvme_ctrl reference to struct nvme_request
drivers/nvme/host/core.c | 5 +-
drivers/nvme/host/fc.c | 1 +
drivers/nvme/host/nvme.h | 1 +
drivers/nvme/host/pci.c | 2 +
drivers/nvme/host/rdma.c | 1 +
drivers/nvme/host/trace.c | 11 ++++
drivers/nvme/host/trace.h | 137 +++++++++++++++++++++++++--------------------
drivers/nvme/target/loop.c | 1 +
8 files changed, 93 insertions(+), 66 deletions(-)
--
2.14.3
next reply other threads:[~2018-06-29 20:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 19:59 Keith Busch [this message]
2018-06-29 19:59 ` [PATCHv3 1/4] nvme: cache struct nvme_ctrl reference to struct nvme_request Keith Busch
2018-06-29 19:59 ` [PATCHv3 2/4] nvme: use hw qid in trace events Keith Busch
2018-06-29 20:23 ` Keith Busch
2018-06-29 19:59 ` [PATCHv3 3/4] nvme: add controller name to " Keith Busch
2018-06-29 20:00 ` [PATCHv3 4/4] nvme: add disk " Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629200000.16171-1-keith.busch@intel.com \
--to=keith.busch@intel.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox