From: Keith Busch <keith.busch@linux.intel.com>
To: Keith Busch <keith.busch@intel.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/4] nvme: use hw qid in trace events
Date: Fri, 29 Jun 2018 14:23:07 -0600 [thread overview]
Message-ID: <20180629202307.GA13865@localhost.localdomain> (raw)
In-Reply-To: <20180629200000.16171-3-keith.busch@intel.com>
On Fri, Jun 29, 2018 at 01:59:58PM -0600, Keith Busch wrote:
> + TP_printk("qid=%d, cmdid=%u, nsid=%u, flags=0x%x, meta=0x%llx, cmd=(%s %s)",
> + __entry->qid, __entry->nsid, __entry->cid,
Ugh, the nsid and cid are swapped here, and carried through to the end
of the series. Will need to send a v4.
next prev parent reply other threads:[~2018-06-29 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 19:59 [PATCHv3 0/4] nvme trace updates Keith Busch
2018-06-29 19:59 ` [PATCHv3 1/4] nvme: cache struct nvme_ctrl reference to struct nvme_request Keith Busch
2018-06-29 19:59 ` [PATCHv3 2/4] nvme: use hw qid in trace events Keith Busch
2018-06-29 20:23 ` Keith Busch [this message]
2018-06-29 19:59 ` [PATCHv3 3/4] nvme: add controller name to " Keith Busch
2018-06-29 20:00 ` [PATCHv3 4/4] nvme: add disk " Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180629202307.GA13865@localhost.localdomain \
--to=keith.busch@linux.intel.com \
--cc=hch@lst.de \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox