From: Huaisheng Ye <yehs2007@zoho.com>
To: dan.j.williams@intel.com
Cc: dave.jiang@intel.com, willy@infradead.org,
ross.zwisler@linux.intel.com, vishal.l.verma@intel.com,
jack@suse.com, chengnt@lenovo.com, linux-nvdimm@lists.01.org,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
Huaisheng Ye <yehs1@lenovo.com>
Subject: [PATCH 2/3] fs/ext2/inode: Fix a type cast error for fsdax
Date: Sun, 1 Jul 2018 14:18:47 +0800 [thread overview]
Message-ID: <20180701061848.7036-2-yehs2007@zoho.com> (raw)
In-Reply-To: <20180701061848.7036-1-yehs2007@zoho.com>
From: Huaisheng Ye <yehs1@lenovo.com>
The type of offset within struct iomap is loff_t, which represents
file offset of mapping.
In ext2_iomap_begin, iomap->offset shall be given a type cast as
loff_t instead of u64.
Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
---
fs/ext2/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index 7163590..ca211bd 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -816,7 +816,7 @@ static int ext2_iomap_begin(struct inode *inode, loff_t offset, loff_t length,
iomap->flags = 0;
iomap->bdev = inode->i_sb->s_bdev;
- iomap->offset = (u64)first_block << blkbits;
+ iomap->offset = (loff_t)first_block << blkbits;
iomap->dax_dev = sbi->s_daxdev;
if (ret == 0) {
--
1.8.3.1
next prev parent reply other threads:[~2018-07-01 6:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-01 6:18 [PATCH 1/3] drivers/dax/super: Add annotation for ops in struct dax_device Huaisheng Ye
2018-07-01 6:18 ` Huaisheng Ye [this message]
2018-07-01 19:26 ` [PATCH 2/3] fs/ext2/inode: Fix a type cast error for fsdax Al Viro
2018-07-02 6:23 ` Huaisheng Ye
2018-07-02 7:55 ` Jan Kara
2018-07-01 6:18 ` [PATCH 3/3] fs/ext2/inode: Optimize the condition for iomap_begin Huaisheng Ye
2018-07-02 7:57 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180701061848.7036-2-yehs2007@zoho.com \
--to=yehs2007@zoho.com \
--cc=chengnt@lenovo.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=yehs1@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox