From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADE3EC6778A for ; Sun, 1 Jul 2018 20:33:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 613A525827 for ; Sun, 1 Jul 2018 20:33:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 613A525827 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbeGAUdw (ORCPT ); Sun, 1 Jul 2018 16:33:52 -0400 Received: from mail.bootlin.com ([62.4.15.54]:39976 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752501AbeGAUdv (ORCPT ); Sun, 1 Jul 2018 16:33:51 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 25D7E207BE; Sun, 1 Jul 2018 22:33:49 +0200 (CEST) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id CDCD7206DE; Sun, 1 Jul 2018 22:33:48 +0200 (CEST) Date: Sun, 1 Jul 2018 22:33:47 +0200 From: Boris Brezillon To: Richard Weinberger Cc: Quentin Schulz , dedekind1@gmail.com, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com Subject: Re: [PATCH v3 2/2] ubi: expose the volume CRC check skip flag Message-ID: <20180701223347.2cef133b@bbrezillon> In-Reply-To: <382648641.QZzOm4Mo72@blindfold> References: <0ace6202bddb495ae0e632ae2fd0346f99fcdab4.1530169759.git-series.quentin.schulz@bootlin.com> <382648641.QZzOm4Mo72@blindfold> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 01 Jul 2018 21:35:57 +0200 Richard Weinberger wrote: > Quentin, > > Am Donnerstag, 28. Juni 2018, 09:40:53 CEST schrieb Quentin Schulz: > > Now that we have the logic for skipping CRC check for static UBI volumes > > in the core, let's expose it to users. > > > > This makes use of a padding byte in the volume description data > > structure as a flag. This flag only tell for now whether we should skip > > the CRC check of a volume. > > > > This checks the UBI volume for which we are trying to skip the CRC check > > is static. > > > > Suggested-by: Boris Brezillon > > Signed-off-by: Quentin Schulz > > Reviewed-by: Boris Brezillon > > --- > > drivers/mtd/ubi/cdev.c | 4 ++++ > > drivers/mtd/ubi/vmt.c | 3 +++ > > include/uapi/mtd/ubi-user.h | 16 ++++++++++++++-- > > 3 files changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c > > index 45c3296..3eea1df 100644 > > --- a/drivers/mtd/ubi/cdev.c > > +++ b/drivers/mtd/ubi/cdev.c > > @@ -622,6 +622,10 @@ static int verify_mkvol_req(const struct ubi_device *ubi, > > req->vol_type != UBI_STATIC_VOLUME) > > goto bad; > > > > + if (req->flags & UBI_VOL_SKIP_CRC_CHECK_FLG && Oops, missed that req->flags & UBI_VOL_SKIP_CRC_CHECK_FLG check was missing parens (checkpatch --strict should complain about that). > > + req->vol_type != UBI_STATIC_VOLUME) > > + goto bad; > > We should also reject unknown flags here. I agree. Talking about missing checks, it seems that none of the padding sections are checked (I hope all mkvol users are zero-ing the struct as requested in ubi-user.h). And we should probably also check that vtbl->flags does not contain unknown flags.