From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 258B0C3279B for ; Mon, 2 Jul 2018 08:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD62625A1C for ; Mon, 2 Jul 2018 08:41:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD62625A1C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964952AbeGBIli (ORCPT ); Mon, 2 Jul 2018 04:41:38 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:44360 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964876AbeGBIlg (ORCPT ); Mon, 2 Jul 2018 04:41:36 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id EBB94AE7; Mon, 2 Jul 2018 08:41:35 +0000 (UTC) Date: Mon, 2 Jul 2018 10:41:33 +0200 From: Greg KH To: John Whitmore Cc: devel@driverdev.osuosl.org, kstewart@linuxfoundation.org, linux-kernel@vger.kernel.org, pombredanne@nexb.com, tglx@linutronix.de Subject: Re: [PATCH 1/3] staging: rtl8192u: Use __func__ instead of hardcoded string - Style Message-ID: <20180702084133.GA25960@kroah.com> References: <20180629181007.18071-1-johnfwhitmore@gmail.com> <20180629181007.18071-2-johnfwhitmore@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180629181007.18071-2-johnfwhitmore@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 29, 2018 at 07:10:05PM +0100, John Whitmore wrote: > Chnaged logging statements to use %s and __func__ instead of hard coding the > function name in a string. > > Signed-off-by: John Whitmore > --- > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > index 1dd4c6ae7319..a4fbc0435de5 100644 > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c > @@ -534,7 +534,7 @@ void HTConstructCapabilityElement(struct ieee80211_device *ieee, u8 *posHTCap, u > //u8 bIsDeclareMCS13; > > if (!posHTCap || !pHT) { > - IEEE80211_DEBUG(IEEE80211_DL_ERR, "posHTCap or pHTInfo can't be null in HTConstructCapabilityElement()\n"); > + IEEE80211_DEBUG(IEEE80211_DL_ERR, "posHTCap or pHTInfo can't be null in %s\n", __func__); You should properly line-wrap thse lines, otherwise you will have to go back and fix them after this patch. thanks, greg k-h