* [PATCH] configfs: Replace strncpy with memcpy
@ 2018-07-01 20:56 Guenter Roeck
2018-07-02 13:14 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2018-07-01 20:56 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Joel Becker, linux-kernel, Guenter Roeck
gcc 8.1.0 complains:
fs/configfs/symlink.c:67:3: warning:
'strncpy' output truncated before terminating nul copying as many
bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here
Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
fs/configfs/symlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/configfs/symlink.c b/fs/configfs/symlink.c
index 78ffc2699993..a5c54af861f7 100644
--- a/fs/configfs/symlink.c
+++ b/fs/configfs/symlink.c
@@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length)
/* back up enough to print this bus id with '/' */
length -= cur;
- strncpy(buffer + length,config_item_name(p),cur);
+ memcpy(buffer + length, config_item_name(p), cur);
*(buffer + --length) = '/';
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configfs: Replace strncpy with memcpy
2018-07-01 20:56 [PATCH] configfs: Replace strncpy with memcpy Guenter Roeck
@ 2018-07-02 13:14 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2018-07-02 13:14 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Christoph Hellwig, Joel Becker, linux-kernel
Thanks Guenter,
applied to the configfs tree for 4.19.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-02 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-01 20:56 [PATCH] configfs: Replace strncpy with memcpy Guenter Roeck
2018-07-02 13:14 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox