public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Xunlei Pang <xlpang@linux.alibaba.com>,
	Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/cputime: Ensure correct utime and stime proportion
Date: Mon, 2 Jul 2018 08:21:06 -0700	[thread overview]
Message-ID: <20180702152106.GD533219@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180626154908.GE2458@hirez.programming.kicks-ass.net>

Hello, Peter.

On Tue, Jun 26, 2018 at 05:49:08PM +0200, Peter Zijlstra wrote:
> Well, no, because the Changelog is incomprehensible and the patch
> doesn't really have useful comments, so I'll have to reverse engineer
> the entire thing, and I've just not had time for that.

Just as an additional data point, we also sometimes see artifacts from
cpu_adjust_time() in the form of per-task user or sys time getting
stuck for some period (in extreme cases for over a minute) while the
application isn't doing anything differently.  We're telling the users
that it's an inherent sampling artifact but it'd be nice to improve it
if possible without adding noticeable overhead.  No idea whether this
patch's approach is a good one tho.

Thanks.

-- 
tejun

  parent reply	other threads:[~2018-07-02 15:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22  7:15 [PATCH] sched/cputime: Ensure correct utime and stime proportion Xunlei Pang
2018-06-22 10:35 ` kbuild test robot
2018-06-25  8:14   ` Xunlei Pang
2018-06-26 12:19 ` Xunlei Pang
2018-06-26 15:49   ` Peter Zijlstra
2018-06-27 12:22     ` Xunlei Pang
2018-07-05 10:46       ` Peter Zijlstra
2018-07-05 13:21         ` Xunlei Pang
2018-07-05 13:42           ` Peter Zijlstra
2018-07-05 13:58             ` xunlei
2018-07-09 10:47               ` Peter Zijlstra
2018-07-09  5:52           ` Xunlei Pang
2018-07-09 10:48             ` Peter Zijlstra
2018-07-09 15:00               ` Xunlei Pang
2018-07-02 15:21     ` Tejun Heo [this message]
2018-07-04  6:56       ` Xunlei Pang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180702152106.GD533219@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=xlpang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox