* [PATCH 1/6] arm64: Make basic compat_* types always available
2018-07-03 5:44 [PATCH 0/6] Introduce struct __kernel_timex Deepa Dinamani
@ 2018-07-03 5:44 ` Deepa Dinamani
2018-07-03 5:44 ` [PATCH 2/6] sparc: Make thread_info.h available directly Deepa Dinamani
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-03 5:44 UTC (permalink / raw)
To: tglx, linux-kernel; +Cc: arnd, y2038, catalin.marinas
As we repurpose more compat syscalls to be used in non CONFIG_COMPAT
usecases as part of solving y2038, we need to make these basic types
available unconditionally.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: catalin.marinas@arm.com
---
arch/arm64/include/asm/compat.h | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h
index 1a037b94eba1..2dbb179b5dc4 100644
--- a/arch/arm64/include/asm/compat.h
+++ b/arch/arm64/include/asm/compat.h
@@ -16,21 +16,14 @@
#ifndef __ASM_COMPAT_H
#define __ASM_COMPAT_H
#ifdef __KERNEL__
-#ifdef CONFIG_COMPAT
-/*
- * Architecture specific compatibility types
- */
#include <linux/types.h>
#include <linux/sched.h>
#include <linux/sched/task_stack.h>
-#define COMPAT_USER_HZ 100
-#ifdef __AARCH64EB__
-#define COMPAT_UTS_MACHINE "armv8b\0\0"
-#else
-#define COMPAT_UTS_MACHINE "armv8l\0\0"
-#endif
+/*
+ * Architecture specific compatibility types
+ */
typedef u32 compat_size_t;
typedef s32 compat_ssize_t;
@@ -65,6 +58,15 @@ typedef u32 compat_ulong_t;
typedef u64 compat_u64;
typedef u32 compat_uptr_t;
+#ifdef CONFIG_COMPAT
+
+#define COMPAT_USER_HZ 100
+#ifdef __AARCH64EB__
+#define COMPAT_UTS_MACHINE "armv8b\0\0"
+#else
+#define COMPAT_UTS_MACHINE "armv8l\0\0"
+#endif
+
struct compat_stat {
#ifdef __AARCH64EB__
short st_dev;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 2/6] sparc: Make thread_info.h available directly
2018-07-03 5:44 [PATCH 0/6] Introduce struct __kernel_timex Deepa Dinamani
2018-07-03 5:44 ` [PATCH 1/6] arm64: Make basic compat_* types always available Deepa Dinamani
@ 2018-07-03 5:44 ` Deepa Dinamani
2018-07-03 9:16 ` David Miller
2018-07-03 5:44 ` [PATCH 3/6] timex: prepare compat helpers for y2038 changes Deepa Dinamani
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-03 5:44 UTC (permalink / raw)
To: tglx, linux-kernel; +Cc: arnd, y2038, davem
linux/compat.h was including this indirectly for
asm/compat.h dependencies.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: davem@davemloft.net
---
arch/sparc/include/asm/compat.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/include/asm/compat.h b/arch/sparc/include/asm/compat.h
index 4eb51d2dae98..1b991cfcdd76 100644
--- a/arch/sparc/include/asm/compat.h
+++ b/arch/sparc/include/asm/compat.h
@@ -5,6 +5,8 @@
* Architecture specific compatibility types
*/
#include <linux/types.h>
+#include <linux/thread_info.h>
+#include <asm/thread_info.h>
#define COMPAT_USER_HZ 100
#define COMPAT_UTS_MACHINE "sparc\0\0"
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 3/6] timex: prepare compat helpers for y2038 changes
2018-07-03 5:44 [PATCH 0/6] Introduce struct __kernel_timex Deepa Dinamani
2018-07-03 5:44 ` [PATCH 1/6] arm64: Make basic compat_* types always available Deepa Dinamani
2018-07-03 5:44 ` [PATCH 2/6] sparc: Make thread_info.h available directly Deepa Dinamani
@ 2018-07-03 5:44 ` Deepa Dinamani
2018-07-05 7:06 ` kbuild test robot
2018-07-03 5:44 ` [PATCH 4/6] time: Add struct __kernel_timex Deepa Dinamani
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-03 5:44 UTC (permalink / raw)
To: tglx, linux-kernel; +Cc: arnd, y2038, linux-arch
Move struct compat_timex to compat_time.h.
This is in line with other compat time structures that are planned
to be deprecated eventually.
Also enable compat_get/put_timex helpers unconditionally.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-arch@vger.kernel.org
---
include/asm-generic/compat.h | 8 ++++-
include/linux/compat.h | 33 -------------------
include/linux/compat_time.h | 34 +++++++++++++++++++
kernel/compat.c | 63 ------------------------------------
kernel/time/time.c | 63 ++++++++++++++++++++++++++++++++++++
5 files changed, 104 insertions(+), 97 deletions(-)
diff --git a/include/asm-generic/compat.h b/include/asm-generic/compat.h
index 28819451b6d1..d2876f43484f 100644
--- a/include/asm-generic/compat.h
+++ b/include/asm-generic/compat.h
@@ -1,3 +1,9 @@
/* SPDX-License-Identifier: GPL-2.0 */
-/* This is an empty stub for 32-bit-only architectures */
+/* This is a stub for 32-bit-only architectures */
+
+#include <linux/types.h>
+
+typedef s32 compat_int_t;
+typedef s32 compat_long_t;
+typedef u32 compat_uint_t;
diff --git a/include/linux/compat.h b/include/linux/compat.h
index df45ee8413d6..2ee58590aeae 100644
--- a/include/linux/compat.h
+++ b/include/linux/compat.h
@@ -19,8 +19,6 @@
#include <linux/uaccess.h>
#include <linux/unistd.h>
-#include <asm/compat.h>
-
#ifdef CONFIG_COMPAT
#include <asm/siginfo.h>
#include <asm/signal.h>
@@ -136,37 +134,6 @@ struct compat_tms {
compat_clock_t tms_cstime;
};
-struct compat_timex {
- compat_uint_t modes;
- compat_long_t offset;
- compat_long_t freq;
- compat_long_t maxerror;
- compat_long_t esterror;
- compat_int_t status;
- compat_long_t constant;
- compat_long_t precision;
- compat_long_t tolerance;
- struct compat_timeval time;
- compat_long_t tick;
- compat_long_t ppsfreq;
- compat_long_t jitter;
- compat_int_t shift;
- compat_long_t stabil;
- compat_long_t jitcnt;
- compat_long_t calcnt;
- compat_long_t errcnt;
- compat_long_t stbcnt;
- compat_int_t tai;
-
- compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
- compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
- compat_int_t:32; compat_int_t:32; compat_int_t:32;
-};
-
-struct timex;
-int compat_get_timex(struct timex *, const struct compat_timex __user *);
-int compat_put_timex(struct compat_timex __user *, const struct timex *);
-
#define _COMPAT_NSIG_WORDS (_COMPAT_NSIG / _COMPAT_NSIG_BPW)
typedef struct {
diff --git a/include/linux/compat_time.h b/include/linux/compat_time.h
index e70bfd1d2c3f..f04454e1b863 100644
--- a/include/linux/compat_time.h
+++ b/include/linux/compat_time.h
@@ -7,6 +7,9 @@
typedef s32 compat_time_t;
+/* TODO: Move to linux/compat.h when this file is deleted. */
+#include <asm/compat.h>
+
struct compat_timespec {
compat_time_t tv_sec;
s32 tv_nsec;
@@ -22,11 +25,42 @@ struct compat_itimerspec {
struct compat_timespec it_value;
};
+struct compat_timex {
+ compat_uint_t modes;
+ compat_long_t offset;
+ compat_long_t freq;
+ compat_long_t maxerror;
+ compat_long_t esterror;
+ compat_int_t status;
+ compat_long_t constant;
+ compat_long_t precision;
+ compat_long_t tolerance;
+ struct compat_timeval time;
+ compat_long_t tick;
+ compat_long_t ppsfreq;
+ compat_long_t jitter;
+ compat_int_t shift;
+ compat_long_t stabil;
+ compat_long_t jitcnt;
+ compat_long_t calcnt;
+ compat_long_t errcnt;
+ compat_long_t stbcnt;
+ compat_int_t tai;
+
+ compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
+ compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
+ compat_int_t:32; compat_int_t:32; compat_int_t:32;
+};
+
+
extern int compat_get_timespec64(struct timespec64 *, const void __user *);
extern int compat_put_timespec64(const struct timespec64 *, void __user *);
extern int get_compat_itimerspec64(struct itimerspec64 *its,
const struct compat_itimerspec __user *uits);
extern int put_compat_itimerspec64(const struct itimerspec64 *its,
struct compat_itimerspec __user *uits);
+struct timex;
+int compat_get_timex(struct timex *, const struct compat_timex __user *);
+int compat_put_timex(struct compat_timex __user *, const struct timex *);
#endif /* _LINUX_COMPAT_TIME_H */
diff --git a/kernel/compat.c b/kernel/compat.c
index 8e40efc2928a..e1de768e5607 100644
--- a/kernel/compat.c
+++ b/kernel/compat.c
@@ -30,69 +30,6 @@
#include <linux/uaccess.h>
-int compat_get_timex(struct timex *txc, const struct compat_timex __user *utp)
-{
- struct compat_timex tx32;
-
- memset(txc, 0, sizeof(struct timex));
- if (copy_from_user(&tx32, utp, sizeof(struct compat_timex)))
- return -EFAULT;
-
- txc->modes = tx32.modes;
- txc->offset = tx32.offset;
- txc->freq = tx32.freq;
- txc->maxerror = tx32.maxerror;
- txc->esterror = tx32.esterror;
- txc->status = tx32.status;
- txc->constant = tx32.constant;
- txc->precision = tx32.precision;
- txc->tolerance = tx32.tolerance;
- txc->time.tv_sec = tx32.time.tv_sec;
- txc->time.tv_usec = tx32.time.tv_usec;
- txc->tick = tx32.tick;
- txc->ppsfreq = tx32.ppsfreq;
- txc->jitter = tx32.jitter;
- txc->shift = tx32.shift;
- txc->stabil = tx32.stabil;
- txc->jitcnt = tx32.jitcnt;
- txc->calcnt = tx32.calcnt;
- txc->errcnt = tx32.errcnt;
- txc->stbcnt = tx32.stbcnt;
-
- return 0;
-}
-
-int compat_put_timex(struct compat_timex __user *utp, const struct timex *txc)
-{
- struct compat_timex tx32;
-
- memset(&tx32, 0, sizeof(struct compat_timex));
- tx32.modes = txc->modes;
- tx32.offset = txc->offset;
- tx32.freq = txc->freq;
- tx32.maxerror = txc->maxerror;
- tx32.esterror = txc->esterror;
- tx32.status = txc->status;
- tx32.constant = txc->constant;
- tx32.precision = txc->precision;
- tx32.tolerance = txc->tolerance;
- tx32.time.tv_sec = txc->time.tv_sec;
- tx32.time.tv_usec = txc->time.tv_usec;
- tx32.tick = txc->tick;
- tx32.ppsfreq = txc->ppsfreq;
- tx32.jitter = txc->jitter;
- tx32.shift = txc->shift;
- tx32.stabil = txc->stabil;
- tx32.jitcnt = txc->jitcnt;
- tx32.calcnt = txc->calcnt;
- tx32.errcnt = txc->errcnt;
- tx32.stbcnt = txc->stbcnt;
- tx32.tai = txc->tai;
- if (copy_to_user(utp, &tx32, sizeof(struct compat_timex)))
- return -EFAULT;
- return 0;
-}
-
static int __compat_get_timeval(struct timeval *tv, const struct compat_timeval __user *ctv)
{
return (!access_ok(VERIFY_READ, ctv, sizeof(*ctv)) ||
diff --git a/kernel/time/time.c b/kernel/time/time.c
index ccdb351277ee..c40cce820380 100644
--- a/kernel/time/time.c
+++ b/kernel/time/time.c
@@ -978,3 +978,66 @@ int put_compat_itimerspec64(const struct itimerspec64 *its,
return 0;
}
EXPORT_SYMBOL_GPL(put_compat_itimerspec64);
+
+int compat_get_timex(struct timex *txc, const struct compat_timex __user *utp)
+{
+ struct compat_timex tx32;
+
+ memset(txc, 0, sizeof(struct timex));
+ if (copy_from_user(&tx32, utp, sizeof(struct compat_timex)))
+ return -EFAULT;
+
+ txc->modes = tx32.modes;
+ txc->offset = tx32.offset;
+ txc->freq = tx32.freq;
+ txc->maxerror = tx32.maxerror;
+ txc->esterror = tx32.esterror;
+ txc->status = tx32.status;
+ txc->constant = tx32.constant;
+ txc->precision = tx32.precision;
+ txc->tolerance = tx32.tolerance;
+ txc->time.tv_sec = tx32.time.tv_sec;
+ txc->time.tv_usec = tx32.time.tv_usec;
+ txc->tick = tx32.tick;
+ txc->ppsfreq = tx32.ppsfreq;
+ txc->jitter = tx32.jitter;
+ txc->shift = tx32.shift;
+ txc->stabil = tx32.stabil;
+ txc->jitcnt = tx32.jitcnt;
+ txc->calcnt = tx32.calcnt;
+ txc->errcnt = tx32.errcnt;
+ txc->stbcnt = tx32.stbcnt;
+
+ return 0;
+}
+
+int compat_put_timex(struct compat_timex __user *utp, const struct timex *txc)
+{
+ struct compat_timex tx32;
+
+ memset(&tx32, 0, sizeof(struct compat_timex));
+ tx32.modes = txc->modes;
+ tx32.offset = txc->offset;
+ tx32.freq = txc->freq;
+ tx32.maxerror = txc->maxerror;
+ tx32.esterror = txc->esterror;
+ tx32.status = txc->status;
+ tx32.constant = txc->constant;
+ tx32.precision = txc->precision;
+ tx32.tolerance = txc->tolerance;
+ tx32.time.tv_sec = txc->time.tv_sec;
+ tx32.time.tv_usec = txc->time.tv_usec;
+ tx32.tick = txc->tick;
+ tx32.ppsfreq = txc->ppsfreq;
+ tx32.jitter = txc->jitter;
+ tx32.shift = txc->shift;
+ tx32.stabil = txc->stabil;
+ tx32.jitcnt = txc->jitcnt;
+ tx32.calcnt = txc->calcnt;
+ tx32.errcnt = txc->errcnt;
+ tx32.stbcnt = txc->stbcnt;
+ tx32.tai = txc->tai;
+ if (copy_to_user(utp, &tx32, sizeof(struct compat_timex)))
+ return -EFAULT;
+ return 0;
+}
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 3/6] timex: prepare compat helpers for y2038 changes
2018-07-03 5:44 ` [PATCH 3/6] timex: prepare compat helpers for y2038 changes Deepa Dinamani
@ 2018-07-05 7:06 ` kbuild test robot
2018-07-05 20:06 ` Deepa Dinamani
0 siblings, 1 reply; 13+ messages in thread
From: kbuild test robot @ 2018-07-05 7:06 UTC (permalink / raw)
To: Deepa Dinamani; +Cc: kbuild-all, tglx, linux-kernel, arnd, y2038, linux-arch
[-- Attachment #1: Type: text/plain, Size: 4651 bytes --]
Hi Deepa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/timers/core]
[also build test ERROR on next-20180704]
[cannot apply to linus/master v4.18-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Deepa-Dinamani/arm64-Make-basic-compat_-types-always-available/20180703-151440
config: riscv-defconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=riscv
All errors (new ones prefixed by >>):
In file included from include/linux/compat.h:10,
from include/linux/ethtool.h:17,
from include/linux/netdevice.h:41,
from drivers/net/mii.c:32:
>> include/linux/compat_time.h:29:2: error: unknown type name 'compat_uint_t'
compat_uint_t modes;
^~~~~~~~~~~~~
>> include/linux/compat_time.h:30:2: error: unknown type name 'compat_long_t'
compat_long_t offset;
^~~~~~~~~~~~~
include/linux/compat_time.h:31:2: error: unknown type name 'compat_long_t'
compat_long_t freq;
^~~~~~~~~~~~~
include/linux/compat_time.h:32:2: error: unknown type name 'compat_long_t'
compat_long_t maxerror;
^~~~~~~~~~~~~
include/linux/compat_time.h:33:2: error: unknown type name 'compat_long_t'
compat_long_t esterror;
^~~~~~~~~~~~~
>> include/linux/compat_time.h:34:2: error: unknown type name 'compat_int_t'
compat_int_t status;
^~~~~~~~~~~~
include/linux/compat_time.h:35:2: error: unknown type name 'compat_long_t'
compat_long_t constant;
^~~~~~~~~~~~~
include/linux/compat_time.h:36:2: error: unknown type name 'compat_long_t'
compat_long_t precision;
^~~~~~~~~~~~~
include/linux/compat_time.h:37:2: error: unknown type name 'compat_long_t'
compat_long_t tolerance;
^~~~~~~~~~~~~
include/linux/compat_time.h:39:2: error: unknown type name 'compat_long_t'
compat_long_t tick;
^~~~~~~~~~~~~
include/linux/compat_time.h:40:2: error: unknown type name 'compat_long_t'
compat_long_t ppsfreq;
^~~~~~~~~~~~~
include/linux/compat_time.h:41:2: error: unknown type name 'compat_long_t'
compat_long_t jitter;
^~~~~~~~~~~~~
include/linux/compat_time.h:42:2: error: unknown type name 'compat_int_t'
compat_int_t shift;
^~~~~~~~~~~~
include/linux/compat_time.h:43:2: error: unknown type name 'compat_long_t'
compat_long_t stabil;
^~~~~~~~~~~~~
include/linux/compat_time.h:44:2: error: unknown type name 'compat_long_t'
compat_long_t jitcnt;
^~~~~~~~~~~~~
include/linux/compat_time.h:45:2: error: unknown type name 'compat_long_t'
compat_long_t calcnt;
^~~~~~~~~~~~~
include/linux/compat_time.h:46:2: error: unknown type name 'compat_long_t'
compat_long_t errcnt;
^~~~~~~~~~~~~
include/linux/compat_time.h:47:2: error: unknown type name 'compat_long_t'
compat_long_t stbcnt;
^~~~~~~~~~~~~
include/linux/compat_time.h:48:2: error: unknown type name 'compat_int_t'
compat_int_t tai;
^~~~~~~~~~~~
>> include/linux/compat_time.h:50:2: error: expected specifier-qualifier-list before 'compat_int_t'
compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
^~~~~~~~~~~~
vim +/compat_uint_t +29 include/linux/compat_time.h
27
28 struct compat_timex {
> 29 compat_uint_t modes;
> 30 compat_long_t offset;
> 31 compat_long_t freq;
32 compat_long_t maxerror;
33 compat_long_t esterror;
> 34 compat_int_t status;
35 compat_long_t constant;
36 compat_long_t precision;
37 compat_long_t tolerance;
38 struct compat_timeval time;
39 compat_long_t tick;
40 compat_long_t ppsfreq;
41 compat_long_t jitter;
42 compat_int_t shift;
43 compat_long_t stabil;
44 compat_long_t jitcnt;
45 compat_long_t calcnt;
> 46 compat_long_t errcnt;
47 compat_long_t stbcnt;
48 compat_int_t tai;
49
> 50 compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
51 compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
52 compat_int_t:32; compat_int_t:32; compat_int_t:32;
53 };
54
55
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 16325 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH 3/6] timex: prepare compat helpers for y2038 changes
2018-07-05 7:06 ` kbuild test robot
@ 2018-07-05 20:06 ` Deepa Dinamani
2018-07-05 20:33 ` Thomas Gleixner
0 siblings, 1 reply; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-05 20:06 UTC (permalink / raw)
To: kbuild test robot
Cc: kbuild-all, Thomas Gleixner, Linux Kernel Mailing List,
Arnd Bergmann, y2038 Mailman List, linux-arch, palmer,
linux-riscv
The error is fixed with the following patch that goes in before patch
3/6 above in the series.
Let me know if I should post a v2 instead.
Thanks,
Deepa
commit bfe4b046ed7f01154aef44fcb77d3f172929ccc2
Author: Deepa Dinamani <deepa.kernel@gmail.com>
Date: Thu Jul 5 11:47:25 2018 -0700
riscv: Include asm-generic/compat.h
riscv does not enable CONFIG_COMPAT in default configurations:
defconfig, allmodconfig and nomodconfig.
And hence does not inlude definitions for compat data types.
Now that time syscalls are being reused in non CONFIG_COMPAT
modes, include asm-generic definitions for riscv.
Alternative would be to make compat_time.h to be conditional on
CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
asm/compat.h include the generic version instead.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: palmer@sifive.com
Cc: linux-riscv@lists.infradead.org
diff --git a/arch/riscv/include/asm/compat.h b/arch/riscv/include/asm/compat.h
index 044aecff8854..e78c5054e178 100644
--- a/arch/riscv/include/asm/compat.h
+++ b/arch/riscv/include/asm/compat.h
@@ -15,6 +15,9 @@
*/
#ifndef __ASM_COMPAT_H
#define __ASM_COMPAT_H
+
+#include <asm-generic/compat.h>
+
#ifdef CONFIG_COMPAT
#if defined(CONFIG_64BIT)
On Thu, Jul 5, 2018 at 12:06 AM, kbuild test robot <lkp@intel.com> wrote:
> Hi Deepa,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on tip/timers/core]
> [also build test ERROR on next-20180704]
> [cannot apply to linus/master v4.18-rc3]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Deepa-Dinamani/arm64-Make-basic-compat_-types-always-available/20180703-151440
> config: riscv-defconfig (attached as .config)
> compiler: riscv64-linux-gcc (GCC) 8.1.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> GCC_VERSION=8.1.0 make.cross ARCH=riscv
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/compat.h:10,
> from include/linux/ethtool.h:17,
> from include/linux/netdevice.h:41,
> from drivers/net/mii.c:32:
>>> include/linux/compat_time.h:29:2: error: unknown type name 'compat_uint_t'
> compat_uint_t modes;
> ^~~~~~~~~~~~~
>>> include/linux/compat_time.h:30:2: error: unknown type name 'compat_long_t'
> compat_long_t offset;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:31:2: error: unknown type name 'compat_long_t'
> compat_long_t freq;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:32:2: error: unknown type name 'compat_long_t'
> compat_long_t maxerror;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:33:2: error: unknown type name 'compat_long_t'
> compat_long_t esterror;
> ^~~~~~~~~~~~~
>>> include/linux/compat_time.h:34:2: error: unknown type name 'compat_int_t'
> compat_int_t status;
> ^~~~~~~~~~~~
> include/linux/compat_time.h:35:2: error: unknown type name 'compat_long_t'
> compat_long_t constant;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:36:2: error: unknown type name 'compat_long_t'
> compat_long_t precision;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:37:2: error: unknown type name 'compat_long_t'
> compat_long_t tolerance;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:39:2: error: unknown type name 'compat_long_t'
> compat_long_t tick;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:40:2: error: unknown type name 'compat_long_t'
> compat_long_t ppsfreq;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:41:2: error: unknown type name 'compat_long_t'
> compat_long_t jitter;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:42:2: error: unknown type name 'compat_int_t'
> compat_int_t shift;
> ^~~~~~~~~~~~
> include/linux/compat_time.h:43:2: error: unknown type name 'compat_long_t'
> compat_long_t stabil;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:44:2: error: unknown type name 'compat_long_t'
> compat_long_t jitcnt;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:45:2: error: unknown type name 'compat_long_t'
> compat_long_t calcnt;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:46:2: error: unknown type name 'compat_long_t'
> compat_long_t errcnt;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:47:2: error: unknown type name 'compat_long_t'
> compat_long_t stbcnt;
> ^~~~~~~~~~~~~
> include/linux/compat_time.h:48:2: error: unknown type name 'compat_int_t'
> compat_int_t tai;
> ^~~~~~~~~~~~
>>> include/linux/compat_time.h:50:2: error: expected specifier-qualifier-list before 'compat_int_t'
> compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
> ^~~~~~~~~~~~
>
> vim +/compat_uint_t +29 include/linux/compat_time.h
>
> 27
> 28 struct compat_timex {
> > 29 compat_uint_t modes;
> > 30 compat_long_t offset;
> > 31 compat_long_t freq;
> 32 compat_long_t maxerror;
> 33 compat_long_t esterror;
> > 34 compat_int_t status;
> 35 compat_long_t constant;
> 36 compat_long_t precision;
> 37 compat_long_t tolerance;
> 38 struct compat_timeval time;
> 39 compat_long_t tick;
> 40 compat_long_t ppsfreq;
> 41 compat_long_t jitter;
> 42 compat_int_t shift;
> 43 compat_long_t stabil;
> 44 compat_long_t jitcnt;
> 45 compat_long_t calcnt;
> > 46 compat_long_t errcnt;
> 47 compat_long_t stbcnt;
> 48 compat_int_t tai;
> 49
> > 50 compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
> 51 compat_int_t:32; compat_int_t:32; compat_int_t:32; compat_int_t:32;
> 52 compat_int_t:32; compat_int_t:32; compat_int_t:32;
> 53 };
> 54
> 55
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [PATCH 3/6] timex: prepare compat helpers for y2038 changes
2018-07-05 20:06 ` Deepa Dinamani
@ 2018-07-05 20:33 ` Thomas Gleixner
2018-07-05 21:45 ` Deepa Dinamani
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Gleixner @ 2018-07-05 20:33 UTC (permalink / raw)
To: Deepa Dinamani
Cc: kbuild test robot, kbuild-all, Linux Kernel Mailing List,
Arnd Bergmann, y2038 Mailman List, linux-arch, palmer,
linux-riscv
On Thu, 5 Jul 2018, Deepa Dinamani wrote:
> The error is fixed with the following patch that goes in before patch
> 3/6 above in the series.
> Let me know if I should post a v2 instead.
>
> Thanks,
> Deepa
>
>
> commit bfe4b046ed7f01154aef44fcb77d3f172929ccc2
> Author: Deepa Dinamani <deepa.kernel@gmail.com>
> Date: Thu Jul 5 11:47:25 2018 -0700
>
> riscv: Include asm-generic/compat.h
>
> riscv does not enable CONFIG_COMPAT in default configurations:
> defconfig, allmodconfig and nomodconfig.
> And hence does not inlude definitions for compat data types.
>
> Now that time syscalls are being reused in non CONFIG_COMPAT
> modes, include asm-generic definitions for riscv.
>
> Alternative would be to make compat_time.h to be conditional on
> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
> asm/compat.h include the generic version instead.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: palmer@sifive.com
> Cc: linux-riscv@lists.infradead.org
Post a real patch please instead of something which I have to cleanup
manually. A V2 of the series is probably the simplest way.
Thanks,
tglx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/6] timex: prepare compat helpers for y2038 changes
2018-07-05 20:33 ` Thomas Gleixner
@ 2018-07-05 21:45 ` Deepa Dinamani
2018-07-06 0:41 ` [kbuild-all] " Philip Li
0 siblings, 1 reply; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-05 21:45 UTC (permalink / raw)
To: Thomas Gleixner, kernel test robot
Cc: kbuild test robot, kbuild-all, Linux Kernel Mailing List,
Arnd Bergmann, y2038 Mailman List, linux-arch, palmer,
linux-riscv
Posted v2 now.
Fengguang,
Also the make.cross script pointed to by the kernel test bot is broken
for riscv.
I applied the following fix to compile it.
Pull request: https://github.com/intel/lkp-tests/pull/11
Thanks,
Deepa
On Thu, Jul 5, 2018 at 1:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 5 Jul 2018, Deepa Dinamani wrote:
>
>> The error is fixed with the following patch that goes in before patch
>> 3/6 above in the series.
>> Let me know if I should post a v2 instead.
>>
>> Thanks,
>> Deepa
>>
>>
>> commit bfe4b046ed7f01154aef44fcb77d3f172929ccc2
>> Author: Deepa Dinamani <deepa.kernel@gmail.com>
>> Date: Thu Jul 5 11:47:25 2018 -0700
>>
>> riscv: Include asm-generic/compat.h
>>
>> riscv does not enable CONFIG_COMPAT in default configurations:
>> defconfig, allmodconfig and nomodconfig.
>> And hence does not inlude definitions for compat data types.
>>
>> Now that time syscalls are being reused in non CONFIG_COMPAT
>> modes, include asm-generic definitions for riscv.
>>
>> Alternative would be to make compat_time.h to be conditional on
>> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
>> asm/compat.h include the generic version instead.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>> Cc: palmer@sifive.com
>> Cc: linux-riscv@lists.infradead.org
>
> Post a real patch please instead of something which I have to cleanup
> manually. A V2 of the series is probably the simplest way.
>
> Thanks,
>
> tglx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [kbuild-all] [PATCH 3/6] timex: prepare compat helpers for y2038 changes
2018-07-05 21:45 ` Deepa Dinamani
@ 2018-07-06 0:41 ` Philip Li
0 siblings, 0 replies; 13+ messages in thread
From: Philip Li @ 2018-07-06 0:41 UTC (permalink / raw)
To: Deepa Dinamani
Cc: Thomas Gleixner, kernel test robot, linux-arch, kbuild test robot,
Arnd Bergmann, y2038 Mailman List, palmer,
Linux Kernel Mailing List, kbuild-all, linux-riscv
On Thu, Jul 05, 2018 at 02:45:05PM -0700, Deepa Dinamani wrote:
> Posted v2 now.
>
> Fengguang,
>
> Also the make.cross script pointed to by the kernel test bot is broken
> for riscv.
>
> I applied the following fix to compile it.
>
> Pull request: https://github.com/intel/lkp-tests/pull/11
thanks Deepa, i will follow up with the pull request to merge it.
>
> Thanks,
> Deepa
>
> On Thu, Jul 5, 2018 at 1:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 5 Jul 2018, Deepa Dinamani wrote:
> >
> >> The error is fixed with the following patch that goes in before patch
> >> 3/6 above in the series.
> >> Let me know if I should post a v2 instead.
> >>
> >> Thanks,
> >> Deepa
> >>
> >>
> >> commit bfe4b046ed7f01154aef44fcb77d3f172929ccc2
> >> Author: Deepa Dinamani <deepa.kernel@gmail.com>
> >> Date: Thu Jul 5 11:47:25 2018 -0700
> >>
> >> riscv: Include asm-generic/compat.h
> >>
> >> riscv does not enable CONFIG_COMPAT in default configurations:
> >> defconfig, allmodconfig and nomodconfig.
> >> And hence does not inlude definitions for compat data types.
> >>
> >> Now that time syscalls are being reused in non CONFIG_COMPAT
> >> modes, include asm-generic definitions for riscv.
> >>
> >> Alternative would be to make compat_time.h to be conditional on
> >> CONFIG_COMPAT_32BIT_TIME. But, since riscv is already has an
> >> asm/compat.h include the generic version instead.
> >>
> >> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> >> Cc: palmer@sifive.com
> >> Cc: linux-riscv@lists.infradead.org
> >
> > Post a real patch please instead of something which I have to cleanup
> > manually. A V2 of the series is probably the simplest way.
> >
> > Thanks,
> >
> > tglx
> _______________________________________________
> kbuild-all mailing list
> kbuild-all@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild-all
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 4/6] time: Add struct __kernel_timex
2018-07-03 5:44 [PATCH 0/6] Introduce struct __kernel_timex Deepa Dinamani
` (2 preceding siblings ...)
2018-07-03 5:44 ` [PATCH 3/6] timex: prepare compat helpers for y2038 changes Deepa Dinamani
@ 2018-07-03 5:44 ` Deepa Dinamani
2018-07-03 5:44 ` [PATCH 5/6] timex: use __kernel_timex internally Deepa Dinamani
2018-07-03 5:44 ` [PATCH 6/6] timex: change syscalls to use struct __kernel_timex Deepa Dinamani
5 siblings, 0 replies; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-03 5:44 UTC (permalink / raw)
To: tglx, linux-kernel; +Cc: arnd, y2038
struct timex uses struct timeval internally.
struct timeval is not y2038 safe.
Introduce a new UAPI type struct __kernel_timex
that is y2038 safe.
struct __kernel_timex uses a timeval type that is
similar to struct __kernel_timespec which preserves the
same structure size across 32 bit and 64 bit ABIs.
struct __kernel_timex also restructures other members of the
structure to make the structure the same on 64 bit and 32 bit
architectures.
Note that struct __kernel_timex is the same as struct timex
on a 64 bit architecture.
The above solution is similar to other new y2038 syscalls
that are being introduced: both 32 bit and 64 bit ABIs
have a common entry, and the compat entry supports the old 32 bit
syscall interface.
Alternatives considered were:
1. Add new time type to struct timex that makes use of padded
bits. This time type could be based on the struct __kernel_timespec.
modes will use a flag to notify which time structure should be
used internally.
This needs some application level changes on both 64 bit and 32 bit
architectures. Although 64 bit machines could continue to use the
older timeval structure without any changes.
2. Add a new u8 type to struct timex that makes use of padded bits. This
can be used to save higher order tv_sec bits. modes will use a flag to
notify presence of such a type.
This will need some application level changes on 32 bit architectures.
3. Add a new compat_timex structure that differs in only the size of the
time type; keep rest of struct timex the same.
This requires extra syscalls to manage all 3 cases on 64 bit
architectures. This will not need any application level changes but will
add more complexity from kernel side.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
---
include/linux/timex.h | 7 +++++++
include/uapi/linux/timex.h | 41 ++++++++++++++++++++++++++++++++++++++
2 files changed, 48 insertions(+)
diff --git a/include/linux/timex.h b/include/linux/timex.h
index 39c25dbebfe8..7f40e9e42ecc 100644
--- a/include/linux/timex.h
+++ b/include/linux/timex.h
@@ -53,6 +53,13 @@
#ifndef _LINUX_TIMEX_H
#define _LINUX_TIMEX_H
+/* CONFIG_64BIT_TIME enables new 64 bit time_t syscalls in the compat path
+ * and 32-bit emulation.
+ */
+#ifndef CONFIG_64BIT_TIME
+#define __kernel_timex timex
+#endif
+
#include <uapi/linux/timex.h>
#define ADJ_ADJTIME 0x8000 /* switch between adjtime/adjtimex modes */
diff --git a/include/uapi/linux/timex.h b/include/uapi/linux/timex.h
index 92685d826444..a1c6b73016a5 100644
--- a/include/uapi/linux/timex.h
+++ b/include/uapi/linux/timex.h
@@ -92,6 +92,47 @@ struct timex {
int :32; int :32; int :32;
};
+struct __kernel_timex_timeval {
+ __kernel_time64_t tv_sec;
+ long long tv_usec;
+};
+
+#ifndef __kernel_timex
+struct __kernel_timex {
+ unsigned int modes; /* mode selector */
+ int :32; /* pad */
+ long long offset; /* time offset (usec) */
+ long long freq; /* frequency offset (scaled ppm) */
+ long long maxerror;/* maximum error (usec) */
+ long long esterror;/* estimated error (usec) */
+ int status; /* clock command/status */
+ int :32; /* pad */
+ long long constant;/* pll time constant */
+ long long precision;/* clock precision (usec) (read only) */
+ long long tolerance;/* clock frequency tolerance (ppm)
+ * (read only)
+ */
+ struct __kernel_timex_timeval time; /* (read only, except for ADJ_SETOFFSET) */
+ long long tick; /* (modified) usecs between clock ticks */
+
+ long long ppsfreq;/* pps frequency (scaled ppm) (ro) */
+ long long jitter; /* pps jitter (us) (ro) */
+ int shift; /* interval duration (s) (shift) (ro) */
+ int :32; /* pad */
+ long long stabil; /* pps stability (scaled ppm) (ro) */
+ long long jitcnt; /* jitter limit exceeded (ro) */
+ long long calcnt; /* calibration intervals (ro) */
+ long long errcnt; /* calibration errors (ro) */
+ long long stbcnt; /* stability limit exceeded (ro) */
+
+ int tai; /* TAI offset (ro) */
+
+ int :32; int :32; int :32; int :32;
+ int :32; int :32; int :32; int :32;
+ int :32; int :32; int :32;
+};
+#endif
+
/*
* Mode codes (timex.mode)
*/
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 5/6] timex: use __kernel_timex internally
2018-07-03 5:44 [PATCH 0/6] Introduce struct __kernel_timex Deepa Dinamani
` (3 preceding siblings ...)
2018-07-03 5:44 ` [PATCH 4/6] time: Add struct __kernel_timex Deepa Dinamani
@ 2018-07-03 5:44 ` Deepa Dinamani
2018-07-03 5:44 ` [PATCH 6/6] timex: change syscalls to use struct __kernel_timex Deepa Dinamani
5 siblings, 0 replies; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-03 5:44 UTC (permalink / raw)
To: tglx, linux-kernel; +Cc: arnd, y2038, linux-alpha, netdev
struct timex is not y2038 safe.
Replace all uses of timex with y2038 safe __kernel_timex.
Note that struct __kernel_timex is an ABI interface definition.
We could define a new structure based on __kernel_timex that
is only available internally instead. Right now, there isn't
a strong motivation for this as the structure is isolated to
a few defined struct timex interfaces and such a structure would
be exactly the same as struct timex.
The patch was generated by the following coccinelle script:
virtual patch
@depends on patch forall@
identifier ts;
expression e;
@@
(
- struct timex ts;
+ struct __kernel_timex ts;
|
- struct timex ts = {};
+ struct __kernel_timex ts = {};
|
- struct timex ts = e;
+ struct __kernel_timex ts = e;
|
- struct timex *ts;
+ struct __kernel_timex *ts;
|
(memset \| copy_from_user \| copy_to_user \)(...,
- sizeof(struct timex))
+ sizeof(struct __kernel_timex))
)
@depends on patch forall@
identifier ts;
identifier fn;
@@
fn(...,
- struct timex *ts,
+ struct __kernel_timex *ts,
...) {
...
}
@depends on patch forall@
identifier ts;
identifier fn;
@@
fn(...,
- struct timex *ts) {
+ struct __kernel_timex *ts) {
...
}
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-alpha@vger.kernel.org
Cc: netdev@vger.kernel.org
---
arch/alpha/kernel/osf_sys.c | 2 +-
drivers/ptp/ptp_clock.c | 2 +-
include/linux/compat_time.h | 6 +++---
include/linux/posix-clock.h | 2 +-
include/linux/timex.h | 2 +-
kernel/time/ntp.c | 12 +++++++-----
kernel/time/ntp_internal.h | 2 +-
kernel/time/posix-clock.c | 2 +-
kernel/time/posix-timers.c | 4 ++--
kernel/time/posix-timers.h | 2 +-
kernel/time/time.c | 14 +++++++-------
kernel/time/timekeeping.c | 4 ++--
12 files changed, 28 insertions(+), 26 deletions(-)
diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c
index 6e921754c8fc..ec86e77d3055 100644
--- a/arch/alpha/kernel/osf_sys.c
+++ b/arch/alpha/kernel/osf_sys.c
@@ -1260,7 +1260,7 @@ struct timex32 {
SYSCALL_DEFINE1(old_adjtimex, struct timex32 __user *, txc_p)
{
- struct timex txc;
+ struct __kernel_timex txc;
int ret;
/* copy relevant bits of struct timex. */
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
index 7eacc1c4b3b1..f2147e9dd3ca 100644
--- a/drivers/ptp/ptp_clock.c
+++ b/drivers/ptp/ptp_clock.c
@@ -121,7 +121,7 @@ static int ptp_clock_gettime(struct posix_clock *pc, struct timespec64 *tp)
return err;
}
-static int ptp_clock_adjtime(struct posix_clock *pc, struct timex *tx)
+static int ptp_clock_adjtime(struct posix_clock *pc, struct __kernel_timex *tx)
{
struct ptp_clock *ptp = container_of(pc, struct ptp_clock, clock);
struct ptp_clock_info *ops;
diff --git a/include/linux/compat_time.h b/include/linux/compat_time.h
index f04454e1b863..25dbd59b3b43 100644
--- a/include/linux/compat_time.h
+++ b/include/linux/compat_time.h
@@ -59,8 +59,8 @@ extern int get_compat_itimerspec64(struct itimerspec64 *its,
const struct compat_itimerspec __user *uits);
extern int put_compat_itimerspec64(const struct itimerspec64 *its,
struct compat_itimerspec __user *uits);
-struct timex;
-int compat_get_timex(struct timex *, const struct compat_timex __user *);
-int compat_put_timex(struct compat_timex __user *, const struct timex *);
+struct __kernel_timex;
+int compat_get_timex(struct __kernel_timex *, const struct compat_timex __user *);
+int compat_put_timex(struct compat_timex __user *, const struct __kernel_timex *);
#endif /* _LINUX_COMPAT_TIME_H */
diff --git a/include/linux/posix-clock.h b/include/linux/posix-clock.h
index 3a3bc71017d5..18674d7d5b1c 100644
--- a/include/linux/posix-clock.h
+++ b/include/linux/posix-clock.h
@@ -51,7 +51,7 @@ struct posix_clock;
struct posix_clock_operations {
struct module *owner;
- int (*clock_adjtime)(struct posix_clock *pc, struct timex *tx);
+ int (*clock_adjtime)(struct posix_clock *pc, struct __kernel_timex *tx);
int (*clock_gettime)(struct posix_clock *pc, struct timespec64 *ts);
diff --git a/include/linux/timex.h b/include/linux/timex.h
index 7f40e9e42ecc..cb894730463c 100644
--- a/include/linux/timex.h
+++ b/include/linux/timex.h
@@ -158,7 +158,7 @@ extern unsigned long tick_nsec; /* SHIFTED_HZ period (nsec) */
#define NTP_INTERVAL_FREQ (HZ)
#define NTP_INTERVAL_LENGTH (NSEC_PER_SEC/NTP_INTERVAL_FREQ)
-extern int do_adjtimex(struct timex *);
+extern int do_adjtimex(struct __kernel_timex *);
extern void hardpps(const struct timespec64 *, const struct timespec64 *);
int read_current_timer(unsigned long *timer_val);
diff --git a/kernel/time/ntp.c b/kernel/time/ntp.c
index 10a79053e82f..7da9eb8adfd4 100644
--- a/kernel/time/ntp.c
+++ b/kernel/time/ntp.c
@@ -189,7 +189,7 @@ static inline int is_error_status(int status)
&& (status & (STA_PPSWANDER|STA_PPSERROR)));
}
-static inline void pps_fill_timex(struct timex *txc)
+static inline void pps_fill_timex(struct __kernel_timex *txc)
{
txc->ppsfreq = shift_right((pps_freq >> PPM_SCALE_INV_SHIFT) *
PPM_SCALE_INV, NTP_SCALE_SHIFT);
@@ -221,7 +221,7 @@ static inline int is_error_status(int status)
return status & (STA_UNSYNC|STA_CLOCKERR);
}
-static inline void pps_fill_timex(struct timex *txc)
+static inline void pps_fill_timex(struct __kernel_timex *txc)
{
/* PPS is not implemented, so these are zero */
txc->ppsfreq = 0;
@@ -642,7 +642,8 @@ void ntp_notify_cmos_timer(void)
/*
* Propagate a new txc->status value into the NTP state:
*/
-static inline void process_adj_status(struct timex *txc, struct timespec64 *ts)
+static inline void process_adj_status(struct __kernel_timex *txc,
+ struct timespec64 *ts)
{
if ((time_status & STA_PLL) && !(txc->status & STA_PLL)) {
time_state = TIME_OK;
@@ -665,7 +666,7 @@ static inline void process_adj_status(struct timex *txc, struct timespec64 *ts)
}
-static inline void process_adjtimex_modes(struct timex *txc,
+static inline void process_adjtimex_modes(struct __kernel_timex *txc,
struct timespec64 *ts,
s32 *time_tai)
{
@@ -718,7 +719,8 @@ static inline void process_adjtimex_modes(struct timex *txc,
* adjtimex mainly allows reading (and writing, if superuser) of
* kernel time-keeping variables. used by xntpd.
*/
-int __do_adjtimex(struct timex *txc, struct timespec64 *ts, s32 *time_tai)
+int __do_adjtimex(struct __kernel_timex *txc, struct timespec64 *ts,
+ s32 *time_tai)
{
int result;
diff --git a/kernel/time/ntp_internal.h b/kernel/time/ntp_internal.h
index 909bd1f1bfb1..4386138bed32 100644
--- a/kernel/time/ntp_internal.h
+++ b/kernel/time/ntp_internal.h
@@ -8,6 +8,6 @@ extern void ntp_clear(void);
extern u64 ntp_tick_length(void);
extern ktime_t ntp_get_next_leap(void);
extern int second_overflow(time64_t secs);
-extern int __do_adjtimex(struct timex *, struct timespec64 *, s32 *);
+extern int __do_adjtimex(struct __kernel_timex *, struct timespec64 *, s32 *);
extern void __hardpps(const struct timespec64 *, const struct timespec64 *);
#endif /* _LINUX_NTP_INTERNAL_H */
diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c
index fe56c4e06c51..a138642553cf 100644
--- a/kernel/time/posix-clock.c
+++ b/kernel/time/posix-clock.c
@@ -241,7 +241,7 @@ static void put_clock_desc(struct posix_clock_desc *cd)
fput(cd->fp);
}
-static int pc_clock_adjtime(clockid_t id, struct timex *tx)
+static int pc_clock_adjtime(clockid_t id, struct __kernel_timex *tx)
{
struct posix_clock_desc cd;
int err;
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index 80d59333c76e..640e30792413 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -209,7 +209,7 @@ static int posix_clock_realtime_set(const clockid_t which_clock,
}
static int posix_clock_realtime_adj(const clockid_t which_clock,
- struct timex *t)
+ struct __kernel_timex *t)
{
return do_adjtimex(t);
}
@@ -1078,7 +1078,7 @@ SYSCALL_DEFINE2(clock_adjtime, const clockid_t, which_clock,
struct timex __user *, utx)
{
const struct k_clock *kc = clockid_to_kclock(which_clock);
- struct timex ktx;
+ struct __kernel_timex ktx;
int err;
if (!kc)
diff --git a/kernel/time/posix-timers.h b/kernel/time/posix-timers.h
index 151e28f5bf30..1d7238084dcd 100644
--- a/kernel/time/posix-timers.h
+++ b/kernel/time/posix-timers.h
@@ -8,7 +8,7 @@ struct k_clock {
const struct timespec64 *tp);
int (*clock_get)(const clockid_t which_clock,
struct timespec64 *tp);
- int (*clock_adj)(const clockid_t which_clock, struct timex *tx);
+ int (*clock_adj)(const clockid_t which_clock, struct __kernel_timex *tx);
int (*timer_create)(struct k_itimer *timer);
int (*nsleep)(const clockid_t which_clock, int flags,
const struct timespec64 *);
diff --git a/kernel/time/time.c b/kernel/time/time.c
index c40cce820380..2c5afb008b14 100644
--- a/kernel/time/time.c
+++ b/kernel/time/time.c
@@ -265,24 +265,24 @@ COMPAT_SYSCALL_DEFINE2(settimeofday, struct compat_timeval __user *, tv,
SYSCALL_DEFINE1(adjtimex, struct timex __user *, txc_p)
{
- struct timex txc; /* Local copy of parameter */
+ struct __kernel_timex txc; /* Local copy of parameter */
int ret;
/* Copy the user data space into the kernel copy
* structure. But bear in mind that the structures
* may change
*/
- if (copy_from_user(&txc, txc_p, sizeof(struct timex)))
+ if (copy_from_user(&txc, txc_p, sizeof(struct __kernel_timex)))
return -EFAULT;
ret = do_adjtimex(&txc);
- return copy_to_user(txc_p, &txc, sizeof(struct timex)) ? -EFAULT : ret;
+ return copy_to_user(txc_p, &txc, sizeof(struct __kernel_timex)) ? -EFAULT : ret;
}
#ifdef CONFIG_COMPAT
COMPAT_SYSCALL_DEFINE1(adjtimex, struct compat_timex __user *, utp)
{
- struct timex txc;
+ struct __kernel_timex txc;
int err, ret;
err = compat_get_timex(&txc, utp);
@@ -979,11 +979,11 @@ int put_compat_itimerspec64(const struct itimerspec64 *its,
}
EXPORT_SYMBOL_GPL(put_compat_itimerspec64);
-int compat_get_timex(struct timex *txc, const struct compat_timex __user *utp)
+int compat_get_timex(struct __kernel_timex *txc, const struct compat_timex __user *utp)
{
struct compat_timex tx32;
- memset(txc, 0, sizeof(struct timex));
+ memset(txc, 0, sizeof(struct __kernel_timex));
if (copy_from_user(&tx32, utp, sizeof(struct compat_timex)))
return -EFAULT;
@@ -1011,7 +1011,7 @@ int compat_get_timex(struct timex *txc, const struct compat_timex __user *utp)
return 0;
}
-int compat_put_timex(struct compat_timex __user *utp, const struct timex *txc)
+int compat_put_timex(struct compat_timex __user *utp, const struct __kernel_timex *txc)
{
struct compat_timex tx32;
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 77c436a0070b..9bb7e977f50e 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -2220,7 +2220,7 @@ ktime_t ktime_get_update_offsets_now(unsigned int *cwsseq, ktime_t *offs_real,
/**
* timekeeping_validate_timex - Ensures the timex is ok for use in do_adjtimex
*/
-static int timekeeping_validate_timex(struct timex *txc)
+static int timekeeping_validate_timex(struct __kernel_timex *txc)
{
if (txc->modes & ADJ_ADJTIME) {
/* singleshot must not be used with any other mode bits */
@@ -2286,7 +2286,7 @@ static int timekeeping_validate_timex(struct timex *txc)
/**
* do_adjtimex() - Accessor function to NTP __do_adjtimex function
*/
-int do_adjtimex(struct timex *txc)
+int do_adjtimex(struct __kernel_timex *txc)
{
struct timekeeper *tk = &tk_core.timekeeper;
unsigned long flags;
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread* [PATCH 6/6] timex: change syscalls to use struct __kernel_timex
2018-07-03 5:44 [PATCH 0/6] Introduce struct __kernel_timex Deepa Dinamani
` (4 preceding siblings ...)
2018-07-03 5:44 ` [PATCH 5/6] timex: use __kernel_timex internally Deepa Dinamani
@ 2018-07-03 5:44 ` Deepa Dinamani
5 siblings, 0 replies; 13+ messages in thread
From: Deepa Dinamani @ 2018-07-03 5:44 UTC (permalink / raw)
To: tglx, linux-kernel; +Cc: arnd, y2038, linux-api
struct timex is not y2038 safe.
Switch all the syscall apis to use y2038 safe __kernel_timex.
Note that sys_adjtimex() does not have a y2038 safe solution.
The api is meant to be deprecated on 32 bit machines after y2038.
Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
Cc: linux-api@vger.kernel.org
---
include/linux/syscalls.h | 5 ++---
kernel/time/posix-timers.c | 10 +---------
kernel/time/time.c | 9 +++++++--
3 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 3ee3b3f1302f..54688c7b4dae 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -54,7 +54,6 @@ struct __sysctl_args;
struct sysinfo;
struct timespec;
struct timeval;
-struct timex;
struct timezone;
struct tms;
struct utimbuf;
@@ -677,7 +676,7 @@ asmlinkage long sys_gettimeofday(struct timeval __user *tv,
struct timezone __user *tz);
asmlinkage long sys_settimeofday(struct timeval __user *tv,
struct timezone __user *tz);
-asmlinkage long sys_adjtimex(struct timex __user *txc_p);
+asmlinkage long sys_adjtimex(struct __kernel_timex __user *txc_p);
/* kernel/timer.c */
asmlinkage long sys_getpid(void);
@@ -846,7 +845,7 @@ asmlinkage long sys_open_by_handle_at(int mountdirfd,
struct file_handle __user *handle,
int flags);
asmlinkage long sys_clock_adjtime(clockid_t which_clock,
- struct timex __user *tx);
+ struct __kernel_timex __user *tx);
asmlinkage long sys_syncfs(int fd);
asmlinkage long sys_setns(int fd, int nstype);
asmlinkage long sys_sendmmsg(int fd, struct mmsghdr __user *msg,
diff --git a/kernel/time/posix-timers.c b/kernel/time/posix-timers.c
index 640e30792413..8ae5d73ecee3 100644
--- a/kernel/time/posix-timers.c
+++ b/kernel/time/posix-timers.c
@@ -1075,7 +1075,7 @@ SYSCALL_DEFINE2(clock_gettime, const clockid_t, which_clock,
}
SYSCALL_DEFINE2(clock_adjtime, const clockid_t, which_clock,
- struct timex __user *, utx)
+ struct __kernel_timex __user *, utx)
{
const struct k_clock *kc = clockid_to_kclock(which_clock);
struct __kernel_timex ktx;
@@ -1150,10 +1150,6 @@ COMPAT_SYSCALL_DEFINE2(clock_gettime, clockid_t, which_clock,
return err;
}
-#endif
-
-#ifdef CONFIG_COMPAT
-
COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
struct compat_timex __user *, utp)
{
@@ -1178,10 +1174,6 @@ COMPAT_SYSCALL_DEFINE2(clock_adjtime, clockid_t, which_clock,
return err;
}
-#endif
-
-#ifdef CONFIG_COMPAT_32BIT_TIME
-
COMPAT_SYSCALL_DEFINE2(clock_getres, clockid_t, which_clock,
struct compat_timespec __user *, tp)
{
diff --git a/kernel/time/time.c b/kernel/time/time.c
index 2c5afb008b14..a374fdbb368b 100644
--- a/kernel/time/time.c
+++ b/kernel/time/time.c
@@ -263,7 +263,10 @@ COMPAT_SYSCALL_DEFINE2(settimeofday, struct compat_timeval __user *, tv,
}
#endif
-SYSCALL_DEFINE1(adjtimex, struct timex __user *, txc_p)
+
+#if !defined(CONFIG_64BIT_TIME) || defined(CONFIG_64BIT)
+
+SYSCALL_DEFINE1(adjtimex, struct __kernel_timex __user *, txc_p)
{
struct __kernel_timex txc; /* Local copy of parameter */
int ret;
@@ -278,7 +281,9 @@ SYSCALL_DEFINE1(adjtimex, struct timex __user *, txc_p)
return copy_to_user(txc_p, &txc, sizeof(struct __kernel_timex)) ? -EFAULT : ret;
}
-#ifdef CONFIG_COMPAT
+#endif
+
+#ifdef CONFIG_COMPAT_32BIT_TIME
COMPAT_SYSCALL_DEFINE1(adjtimex, struct compat_timex __user *, utp)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 13+ messages in thread