From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F25CC6778A for ; Tue, 3 Jul 2018 06:20:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E622220836 for ; Tue, 3 Jul 2018 06:20:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E622220836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933028AbeGCGUL (ORCPT ); Tue, 3 Jul 2018 02:20:11 -0400 Received: from muru.com ([72.249.23.125]:49672 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932883AbeGCGUK (ORCPT ); Tue, 3 Jul 2018 02:20:10 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3B32E80C8; Tue, 3 Jul 2018 06:23:06 +0000 (UTC) Date: Mon, 2 Jul 2018 23:20:07 -0700 From: Tony Lindgren To: Kees Cook Cc: LKML , Arnd Bergmann Subject: Re: [PATCH] bus: ti-sysc: Use 2-factor allocator arguments Message-ID: <20180703062007.GA112168@atomide.com> References: <20180618174549.GA1893@beast> <20180702112719.GU112168@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kees Cook [180702 16:17]: > On Mon, Jul 2, 2018 at 4:27 AM, Tony Lindgren wrote: > > * Kees Cook [180627 21:59]: > >> On Mon, Jun 18, 2018 at 10:45 AM, Kees Cook wrote: > >> > This adjusts the allocator calls to use 2-factor argument call style, as > >> > done treewide already for improved defense against allocation overflows. > >> > > >> > Signed-off-by: Kees Cook > >> > >> Friendly ping! :) This is the last 2-factor devm* allocation left in > >> 4.18 to be fixed. > > > > Sorry for the delay on this one. As we're already at -rc3, I'll apply > > this into omap-for-v4.19/ti-sysc. Seems there should not be need to rush > > this into v4.18-rc cycle, but please do let me know if that is not the > > case. > > I'd like to be able to reason about multiplication vs allocator uses > in 4.18 and later. Since all other allocators got fixed in 4.18, I'd > really like to have this one fixed too, then the scripts that check > for multiplications in single-argument allocators will run clean for > 4.18. > > So, it's not strictly a "rush", but it would be appreciated. :) OK I'll merge that commit also into omap-for-v4.18/fixes branch too. Regards, Tony