From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B1ADC6778C for ; Tue, 3 Jul 2018 07:07:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 474EE24899 for ; Tue, 3 Jul 2018 07:07:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 474EE24899 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932363AbeGCHHt (ORCPT ); Tue, 3 Jul 2018 03:07:49 -0400 Received: from muru.com ([72.249.23.125]:49756 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932095AbeGCHHq (ORCPT ); Tue, 3 Jul 2018 03:07:46 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 13BB78047; Tue, 3 Jul 2018 07:10:41 +0000 (UTC) Date: Tue, 3 Jul 2018 00:07:43 -0700 From: Tony Lindgren To: Faiz Abbas Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mark.rutland@arm.com, paul@pwsan.com, t-kristo@ti.com, robh+dt@kernel.org, bcousson@baylibre.com Subject: Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset Message-ID: <20180703070743.GG112168@atomide.com> References: <20180606060826.14671-5-faiz_abbas@ti.com> <20180607073530.GH5738@atomide.com> <20180608062158.GI5738@atomide.com> <20180611060957.GN5738@atomide.com> <20180611062904.GO5738@atomide.com> <89d55b0b-fe9e-793b-2694-25755ac2bc15@ti.com> <20180611070332.GP5738@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180611070332.GP5738@atomide.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [180611 07:06]: > * Faiz Abbas [180611 06:48]: > > Hi, > > > > On Monday 11 June 2018 11:59 AM, Tony Lindgren wrote: > > > * Faiz Abbas [180611 06:28]: > > >> Great. I thought I completely misunderstood you. But I don't see what > > >> adding another function will accomplish. A QUIRK flag used in the same > > >> function would work well enough> > > > Fine with me as long as the function stays simple for both > > > syss and sysc reset. > > > > > > > > > In general a reset status bit being in sysstatus is the norm and it > > being in sysconfig should be the "quirk" for which a flag needs to be > > added. What do you think? > > Sure makes sense to me. > > > As an aside, naming bitshifts by the name of the platform they were > > originally added in seems weird. There should be some generic mask > > saying "soft reset is the 0th bit". Currently I am using > > SYSC_OMAP4_SOFTRESET for a dra76x module. I guess it depends on how many > > different sysconfig types we have. > > Sure we could have a macro for that. So what's the conclusion on this one? Are you going to do one more version of the ti-sysc driver patch? Regards, Tony