From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC9DC6778C for ; Tue, 3 Jul 2018 07:31:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCDE9208A4 for ; Tue, 3 Jul 2018 07:31:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCDE9208A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754610AbeGCHbz (ORCPT ); Tue, 3 Jul 2018 03:31:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:57720 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754218AbeGCHbx (ORCPT ); Tue, 3 Jul 2018 03:31:53 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w637TAiT005721 for ; Tue, 3 Jul 2018 03:31:52 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k02d85by8-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Jul 2018 03:31:52 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Jul 2018 08:31:49 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Jul 2018 08:31:43 +0100 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w637Vhoh40829078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 3 Jul 2018 07:31:43 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E5587AE063; Tue, 3 Jul 2018 10:31:45 +0100 (BST) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CF84AAE05D; Tue, 3 Jul 2018 10:31:45 +0100 (BST) Received: from lynx.boeblingen.de.ibm.com (unknown [9.152.212.204]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 3 Jul 2018 10:31:45 +0100 (BST) Received: from brueckh by lynx.boeblingen.de.ibm.com with local (Exim 4.90_1) (envelope-from ) id 1faFmo-0002hM-GU; Tue, 03 Jul 2018 09:31:42 +0200 Date: Tue, 3 Jul 2018 09:31:42 +0200 From: Hendrik Brueckner To: Mathieu Poirier Cc: peterz@infradead.org, acme@kernel.org, mingo@redhat.com, tglx@linutronix.de, alexander.shishkin@linux.intel.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, will.deacon@arm.com, mark.rutland@arm.com, jolsa@redhat.com, namhyung@kernel.org, adrian.hunter@intel.com, ast@kernel.org, gregkh@linuxfoundation.org, hpa@zytor.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/6] perf/aux: Make perf_event accessible to setup_aux() References: <1530570810-28929-1-git-send-email-mathieu.poirier@linaro.org> <1530570810-28929-5-git-send-email-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1530570810-28929-5-git-send-email-mathieu.poirier@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 18070307-0020-0000-0000-000002A2813A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18070307-0021-0000-0000-000020EE96D0 Message-Id: <20180703073142.GA4581@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-03_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807030086 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 02, 2018 at 04:33:28PM -0600, Mathieu Poirier wrote: > It can be advantagous to have access to all the information conveyed by > a perf_event when setting up the AUX buffer, as it is the case when > dealing with PMU specific driver configuration communicated to the kernel > using an ioctl() call. > > As such simply replace the cpu information by the complete perf_event > structure and change all affected customers. > > Signed-off-by: Mathieu Poirier > --- > arch/s390/kernel/perf_cpum_sf.c | 4 ++-- > arch/x86/events/intel/bts.c | 4 +++- > arch/x86/events/intel/pt.c | 5 +++-- > drivers/hwtracing/coresight/coresight-etm-perf.c | 6 +++--- > drivers/perf/arm_spe_pmu.c | 6 +++--- > include/linux/perf_event.h | 2 +- > kernel/events/ring_buffer.c | 2 +- > 7 files changed, 16 insertions(+), 13 deletions(-) > > diff --git a/arch/s390/kernel/perf_cpum_sf.c b/arch/s390/kernel/perf_cpum_sf.c > index 0292d68e7dde..e06daaa08894 100644 > --- a/arch/s390/kernel/perf_cpum_sf.c > +++ b/arch/s390/kernel/perf_cpum_sf.c > @@ -1601,8 +1601,8 @@ static void aux_buffer_free(void *data) > * > * Return the private AUX buffer structure if success or NULL if fails. > */ > -static void *aux_buffer_setup(int cpu, void **pages, int nr_pages, > - bool snapshot) > +static void *aux_buffer_setup(struct perf_event *event, void **pages, > + int nr_pages, bool snapshot); Please remove the trailing semi-colon (;) in the function definition causing the kbuild error. Also, it would be great if you also could update the function comment and replace the @cpu by the @event. Many thanks.