From: Johan Hovold <johan@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] gnss: fix potential error pointer dereference
Date: Tue, 3 Jul 2018 14:11:43 +0200 [thread overview]
Message-ID: <20180703121143.GP9802@localhost> (raw)
In-Reply-To: <20180703115921.7h35wi73oym3use5@kili.mountain>
On Tue, Jul 03, 2018 at 02:59:22PM +0300, Dan Carpenter wrote:
> The gnss_allocate_device() function returns a mix of NULL and error
> pointers on error. It should only return one or the other. Since the
> callers both check for NULL, I've modified it to return NULL on error.
>
> Fixes: 10f146639fee ("gnss: add receiver type support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Ouch, thanks for catching this!
I think you got the wrong commit for the fixes tag above, however. That
should be:
Fixes: 2b6a44035143 ("gnss: add GNSS receiver subsystem")
Not sure if you want to send a v2, or if Greg can fix that when
applying. Apart from that:
Acked-by: Johan Hovold <johan@kernel.org>
Johan
next prev parent reply other threads:[~2018-07-03 12:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 11:59 [PATCH] gnss: fix potential error pointer dereference Dan Carpenter
2018-07-03 12:11 ` Johan Hovold [this message]
2018-07-03 12:23 ` Dan Carpenter
2018-07-03 12:25 ` [PATCH v2] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703121143.GP9802@localhost \
--to=johan@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox