From: Guenter Roeck <linux@roeck-us.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
Date: Tue, 3 Jul 2018 08:40:27 -0700 [thread overview]
Message-ID: <20180703154027.GA1180@roeck-us.net> (raw)
In-Reply-To: <fb51cbf8adfe2b50ce2b3fe0e6851ef5982d12db.camel@kernel.crashing.org>
On Wed, Jul 04, 2018 at 12:23:20AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2018-07-03 at 06:43 -0700, Guenter Roeck wrote:
> > The driver calls of_platform_device_create() which is only available
> > if OF_ADDRESS is enabled. When building sparc64 images, this results
> > in
> >
> > ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
> >
> > Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>
> Thanks Guenter ! I'll include this into the fsi tree.
>
> (I was wondering what that kbuild report on sparc64 was about... I must
> have misread the code, I didn't realize of_platform_device_create
> wasn't under CONFIG_OF alone).
>
No worries; pretty much everyone using one of the affected functions
falls into that trap.
Guenter
prev parent reply other threads:[~2018-07-03 15:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-03 13:43 [PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS Guenter Roeck
2018-07-03 14:23 ` Benjamin Herrenschmidt
2018-07-03 15:40 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703154027.GA1180@roeck-us.net \
--to=linux@roeck-us.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox