From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE7FC6778C for ; Tue, 3 Jul 2018 16:47:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34D2D23C19 for ; Tue, 3 Jul 2018 16:47:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34D2D23C19 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934181AbeGCQrp (ORCPT ); Tue, 3 Jul 2018 12:47:45 -0400 Received: from mga17.intel.com ([192.55.52.151]:62863 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933860AbeGCQrn (ORCPT ); Tue, 3 Jul 2018 12:47:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 09:47:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,304,1526367600"; d="scan'208";a="242334720" Received: from theros.lm.intel.com (HELO linux.intel.com) ([10.232.112.164]) by fmsmga005.fm.intel.com with ESMTP; 03 Jul 2018 09:47:42 -0700 Date: Tue, 3 Jul 2018 10:47:41 -0600 From: Ross Zwisler To: Dan Williams Cc: mingo@kernel.org, Al Viro , Andrew Morton , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Tony Luck , Ross Zwisler , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] lib/iov_iter: Fix pipe handling in _copy_to_iter_mcsafe Message-ID: <20180703164741.GA30451@linux.intel.com> Mail-Followup-To: Ross Zwisler , Dan Williams , mingo@kernel.org, Al Viro , Andrew Morton , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Tony Luck , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <153046008813.2019.6356018879675062644.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <153046008813.2019.6356018879675062644.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 01, 2018 at 08:52:20AM -0700, Dan Williams wrote: > By mistake the ITER_PIPE early-exit / warning from copy_from_iter() was > cargo-culted in _copy_to_iter_mcsafe() rather than a machine-check-safe > version of copy_to_iter_pipe(). > > Implement copy_pipe_to_iter_mcsafe() being careful to return the > indication of short copies due to a CPU exception. > > Without this regression-fix all splice reads to dax-mode files fail. > > Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()") > Cc: Al Viro > Cc: Andrew Morton > Cc: Andy Lutomirski > Cc: Borislav Petkov > Cc: Linus Torvalds > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Tony Luck > Reported-by: Ross Zwisler > Signed-off-by: Dan Williams Tested-by: Ross Zwisler