From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78208C6778A for ; Tue, 3 Jul 2018 16:59:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CD8421386 for ; Tue, 3 Jul 2018 16:59:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CD8421386 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934199AbeGCQ67 (ORCPT ); Tue, 3 Jul 2018 12:58:59 -0400 Received: from mga12.intel.com ([192.55.52.136]:32759 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934176AbeGCQ6w (ORCPT ); Tue, 3 Jul 2018 12:58:52 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 09:58:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,304,1526367600"; d="scan'208";a="69782976" Received: from agluck-desk.sc.intel.com (HELO agluck-desk) ([10.3.52.160]) by orsmga001.jf.intel.com with ESMTP; 03 Jul 2018 09:58:49 -0700 Date: Tue, 3 Jul 2018 09:58:49 -0700 From: "Luck, Tony" To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, Borislav Petkov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-edac@vger.kernel.org Subject: Re: [PATCH] x86/MCE: Fix CPU microcode version output Message-ID: <20180703165849.GA17773@agluck-desk> References: <20180703164844.9742-1-prarit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180703164844.9742-1-prarit@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 03, 2018 at 12:48:44PM -0400, Prarit Bhargava wrote: > On systems where a runtime microcode update has occurred the > microcode version is wrong because boot_cpu_data.microcode is > not updated during runtime. > > Use the per-CPU microcode version in the MCE message. Other option would be to fix the microcode update code to make sure that boot_cpu_data.microcode is right. But if we go this route we should add: Fixes: fa94d0c6e0f3 ("x86/MCE: Save microcode revision in machine check records") Cc: stable@vger.kernel.org Can also get a: Reviewed-by: Tony Luck -Tony Luck