* [PATCH] lightnvm: pblk: mark expected switch fall-through
@ 2018-07-03 21:21 Gustavo A. R. Silva
2018-07-04 8:07 ` Matias Bjørling
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-07-03 21:21 UTC (permalink / raw)
To: Matias Bjorling; +Cc: linux-block, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/lightnvm/pblk-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index ed9cc97..9c93334 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -264,6 +264,7 @@ void pblk_free_rqd(struct pblk *pblk, struct nvm_rq *rqd, int type)
switch (type) {
case PBLK_WRITE:
kfree(((struct pblk_c_ctx *)nvm_rq_to_pdu(rqd))->lun_bitmap);
+ /* fall through */
case PBLK_WRITE_INT:
pool = &pblk->w_rq_pool;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] lightnvm: pblk: mark expected switch fall-through
2018-07-03 21:21 [PATCH] lightnvm: pblk: mark expected switch fall-through Gustavo A. R. Silva
@ 2018-07-04 8:07 ` Matias Bjørling
2018-07-04 13:00 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Matias Bjørling @ 2018-07-04 8:07 UTC (permalink / raw)
To: gustavo; +Cc: linux-block, linux-kernel
On 07/03/2018 11:21 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/lightnvm/pblk-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index ed9cc97..9c93334 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -264,6 +264,7 @@ void pblk_free_rqd(struct pblk *pblk, struct nvm_rq *rqd, int type)
> switch (type) {
> case PBLK_WRITE:
> kfree(((struct pblk_c_ctx *)nvm_rq_to_pdu(rqd))->lun_bitmap);
> + /* fall through */
> case PBLK_WRITE_INT:
> pool = &pblk->w_rq_pool;
> break;
>
Thanks Gustavo. Applied for 4.19.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lightnvm: pblk: mark expected switch fall-through
2018-07-04 8:07 ` Matias Bjørling
@ 2018-07-04 13:00 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-07-04 13:00 UTC (permalink / raw)
To: Matias Bjørling; +Cc: linux-block, linux-kernel
On 07/04/2018 03:07 AM, Matias Bjørling wrote:
> On 07/03/2018 11:21 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/lightnvm/pblk-core.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
>> index ed9cc97..9c93334 100644
>> --- a/drivers/lightnvm/pblk-core.c
>> +++ b/drivers/lightnvm/pblk-core.c
>> @@ -264,6 +264,7 @@ void pblk_free_rqd(struct pblk *pblk, struct nvm_rq *rqd, int type)
>> switch (type) {
>> case PBLK_WRITE:
>> kfree(((struct pblk_c_ctx *)nvm_rq_to_pdu(rqd))->lun_bitmap);
>> + /* fall through */
>> case PBLK_WRITE_INT:
>> pool = &pblk->w_rq_pool;
>> break;
>>
>
> Thanks Gustavo. Applied for 4.19.
Thanks, Matias.
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-04 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 21:21 [PATCH] lightnvm: pblk: mark expected switch fall-through Gustavo A. R. Silva
2018-07-04 8:07 ` Matias Bjørling
2018-07-04 13:00 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox