From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, insafonov@gmail.com,
baijiaju1990@gmail.com, keescook@chromium.org, joe@perches.com,
colin.king@canonical.com, gregkh@linuxfoundation.org,
John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH v2 2/9] staging: rtl8192u: Use memset to initialize memory, instead of loop.
Date: Wed, 4 Jul 2018 15:20:49 +0100 [thread overview]
Message-ID: <20180704142056.2179-2-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180704142056.2179-1-johnfwhitmore@gmail.com>
Replaced memory initialising loop with memset instead.
Suggested-by: Andy Shevchenko
Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
index a549d9678214..abf55877331e 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
@@ -761,8 +761,6 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
*/
static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
{
- u8 i;
-
if (!pOperateMCS) {
IEEE80211_DEBUG(IEEE80211_DL_ERR,
"pOperateMCS can't be null in %s\n",
@@ -777,8 +775,7 @@ static u8 HT_PickMCSRate(struct ieee80211_device *ieee, u8 *pOperateMCS)
//legacy rate routine handled at selectedrate
//no MCS rate
- for (i = 0; i <= 15; i++)
- pOperateMCS[i] = 0;
+ memset(pOperateMCS, 0, 16);
break;
case IEEE_N_24G: //assume CCK rate ok
--
2.17.1
next prev parent reply other threads:[~2018-07-04 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 14:20 [PATCH v2 1/9] staging: rtl8192u: Use __func__ instead of hardcoded string - Style John Whitmore
2018-07-04 14:20 ` John Whitmore [this message]
2018-07-04 14:20 ` [PATCH v2 3/9] staging: rtl8192u: Remove redundant definitions in header John Whitmore
2018-07-04 14:20 ` [PATCH v2 4/9] staging: rtl8192u: Remove superfluous blank lines - Coding Style John Whitmore
2018-07-04 14:20 ` [PATCH v2 5/9] staging: rtl8192u: Add space required around '==' opeartor - Style John Whitmore
2018-07-04 14:20 ` [PATCH v2 6/9] staging: rtl8192u: Add required spaces around '||' operator - Sytle John Whitmore
2018-07-04 14:20 ` [PATCH v2 7/9] staging: rtl8192u: Remove space after cast - Coding Style John Whitmore
2018-07-04 14:20 ` [PATCH v2 8/9] staging: rtl8192u: Add required space around '=' operator - Style John Whitmore
2018-07-04 14:20 ` [PATCH v2 9/9] staging: rtl8192u: Add space after ',' character - Coding Style John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704142056.2179-2-johnfwhitmore@gmail.com \
--to=johnfwhitmore@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox