From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8D7C3279B for ; Wed, 4 Jul 2018 14:25:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6C2D62089D for ; Wed, 4 Jul 2018 14:25:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="49A6HDVa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C2D62089D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753117AbeGDOZ1 (ORCPT ); Wed, 4 Jul 2018 10:25:27 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:51782 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752496AbeGDOZZ (ORCPT ); Wed, 4 Jul 2018 10:25:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=e3HMUf5ZJHl+MeA9vLt4Rp0/nj6Lth3baH+ohTvEbbw=; b=49A6HDVaRtaSBWmtPoRG3WJeymqevP1bN7FdmHZk0YaniX+H4lCkJa34ck16UJ39B1Hj3DnRUJYG7pG+1RjmvGfAbrXwyv90Zd2Mwk7sod0uE6bPo3Puy54BxzLm2masDAMS+WwYjFhb8UKnHkZJ/ZTsnnSSCdwszV8QuTwayWc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1faiie-0003j8-9w; Wed, 04 Jul 2018 16:25:20 +0200 Date: Wed, 4 Jul 2018 16:25:20 +0200 From: Andrew Lunn To: Colin King Cc: Vivien Didelot , Florian Fainelli , "David S . Miller" , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: dsa: bcm_sf2: remove redundant variable off Message-ID: <20180704142520.GD12405@lunn.ch> References: <20180704065436.13719-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180704065436.13719-1-colin.king@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian I this a bug? It seems to be a result of moving to b53_disable_port() in f86ad77faf. Before you would handle the CPU port differently than a normal port. After this change, there is no difference? Andrew