From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 700C3C3279B for ; Wed, 4 Jul 2018 17:44:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A4AD241E2 for ; Wed, 4 Jul 2018 17:44:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A4AD241E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbeGDRoO (ORCPT ); Wed, 4 Jul 2018 13:44:14 -0400 Received: from foss.arm.com ([217.140.101.70]:41330 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165AbeGDRoN (ORCPT ); Wed, 4 Jul 2018 13:44:13 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B23C27A9; Wed, 4 Jul 2018 10:44:12 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 80FBF3F5A0; Wed, 4 Jul 2018 10:44:12 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 2862E1AE180C; Wed, 4 Jul 2018 18:44:52 +0100 (BST) Date: Wed, 4 Jul 2018 18:44:52 +0100 From: Will Deacon To: Mark Rutland Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, boqun.feng@gmail.com Subject: Re: [PATCHv2 08/11] atomics: switch to generated fallbacks Message-ID: <20180704174451.GE9668@arm.com> References: <20180625105952.3756-1-mark.rutland@arm.com> <20180625105952.3756-9-mark.rutland@arm.com> <20180704152846.GL4828@arm.com> <20180704160145.kyzzymyufv3kt52l@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180704160145.kyzzymyufv3kt52l@lakrids.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 04, 2018 at 05:01:46PM +0100, Mark Rutland wrote: > On Wed, Jul 04, 2018 at 04:28:47PM +0100, Will Deacon wrote: > > On Mon, Jun 25, 2018 at 11:59:49AM +0100, Mark Rutland wrote: > > > As a step to ensuring the atomic* APIs are consistent, switch to fallbacks > > > generated by gen-atomic-fallback.sh. > > > > > > These are checked in rather than generated with Kbuild, since: > > > > > > * This allows inspection of the atomics with git grep and ctags on a > > > pristine tree, which Linus strongly prefers being able to do. > > > > > > * The fallbacks are not expected to change very often, and are not > > > affected by machine details or configuration options, so regenerating > > > them for *every* build is somewhat wasteful. > > > > > > * These are included by files required *very* early in the build process > > > (e.g. for generating bounds.h), and we'd rather not complicate the > > > top-level Kbuild file. > > > > Would it be worth checking that the generated output from the script doesn't > > differ from the file in tree at some point during the build, and issuing a > > warning if they do? > > We could do that in the top-level Kbuild file. It would be less hideous > than the generation was, since we don't have to add dependencies to all > other targets. > > I can take a look, if you'd like? Yes, please. Might also be worth having your "THIS FILE IS GENERATED" disclaimer before each function, as I completely missed it when I opened the file since it just looks like part of the license and jumping around with ctags might dump you halfway down the file. Will