Re: [PATCH v2 bpf-next 02/14] bpf: introduce cgroup storage maps

kbuild test robot
2018-07-06T14:43:02Z

[-- Attachment #1: Type: text/plain, Size: 2423 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/bpf-cgroup-local-storage/20180706-055938
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: s390-performance_defconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=s390

All errors (new ones prefixed by >>):

In file included from kernel//bpf/local_storage.c:2:0:
include/linux/bpf-cgroup.h: In function 'cgroup_bpf_prog_attach':
>> include/linux/bpf-cgroup.h:237:10: error: 'EINVAL' undeclared (first use in this function)
return -EINVAL;
^~~~~~
include/linux/bpf-cgroup.h:237:10: note: each undeclared identifier is reported only once for each function it appears in
include/linux/bpf-cgroup.h: In function 'cgroup_bpf_prog_detach':
include/linux/bpf-cgroup.h:243:10: error: 'EINVAL' undeclared (first use in this function)
return -EINVAL;
^~~~~~
include/linux/bpf-cgroup.h: In function 'cgroup_bpf_prog_query':
include/linux/bpf-cgroup.h:249:10: error: 'EINVAL' undeclared (first use in this function)
return -EINVAL;
^~~~~~

vim +/EINVAL +237 include/linux/bpf-cgroup.h

30070984 Daniel Mack 2016-11-23 232
fdb5c453 Sean Young 2018-06-19 233 static inline int cgroup_bpf_prog_attach(const union bpf_attr *attr,
fdb5c453 Sean Young 2018-06-19 234 enum bpf_prog_type ptype,
fdb5c453 Sean Young 2018-06-19 235 struct bpf_prog *prog)
fdb5c453 Sean Young 2018-06-19 236 {
fdb5c453 Sean Young 2018-06-19 @237 return -EINVAL;
fdb5c453 Sean Young 2018-06-19 238 }
fdb5c453 Sean Young 2018-06-19 239

:::::: The code at line 237 was first introduced by commit
:::::: fdb5c4531c1e0e50e609df83f736b6f3a02896e2 bpf: fix attach type BPF_LIRC_MODE2 dependency wrt CONFIG_CGROUP_BPF

:::::: TO: Sean Young <sean@mess.org>
:::::: CC: Daniel Borkmann <daniel@iogearbox.net>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 19173 bytes --]