Re: [PATCH v2 bpf-next 05/14] bpf: extend bpf_prog_array to store pointers to the cgroup storage

kbuild test robot
2018-07-06T07:51:39Z

[-- Attachment #1: Type: text/plain, Size: 2304 bytes --]

Hi Roman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/bpf-cgroup-local-storage/20180706-055938
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-randconfig-u0-07061335 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All errors (new ones prefixed by >>):

drivers/media//rc/bpf-lirc.c: In function 'lirc_bpf_free':
>> drivers/media//rc/bpf-lirc.c:203:44: error: 'struct bpf_prog_array' has no member named 'progs'
progs = rcu_dereference(rcdev->raw->progs)->progs;
^

vim +203 drivers/media//rc/bpf-lirc.c

f4364dcf Sean Young 2018-05-27 191
f4364dcf Sean Young 2018-05-27 192 /*
f4364dcf Sean Young 2018-05-27 193 * This should be called once the rc thread has been stopped, so there can be
f4364dcf Sean Young 2018-05-27 194 * no concurrent bpf execution.
f4364dcf Sean Young 2018-05-27 195 */
f4364dcf Sean Young 2018-05-27 196 void lirc_bpf_free(struct rc_dev *rcdev)
f4364dcf Sean Young 2018-05-27 197 {
f4364dcf Sean Young 2018-05-27 198 struct bpf_prog **progs;
f4364dcf Sean Young 2018-05-27 199
f4364dcf Sean Young 2018-05-27 200 if (!rcdev->raw->progs)
f4364dcf Sean Young 2018-05-27 201 return;
f4364dcf Sean Young 2018-05-27 202
f4364dcf Sean Young 2018-05-27 @203 progs = rcu_dereference(rcdev->raw->progs)->progs;
f4364dcf Sean Young 2018-05-27 204 while (*progs)
f4364dcf Sean Young 2018-05-27 205 bpf_prog_put(*progs++);
f4364dcf Sean Young 2018-05-27 206
f4364dcf Sean Young 2018-05-27 207 bpf_prog_array_free(rcdev->raw->progs);
f4364dcf Sean Young 2018-05-27 208 }
f4364dcf Sean Young 2018-05-27 209

:::::: The code at line 203 was first introduced by commit
:::::: f4364dcfc86df7c1ca47b256eaf6b6d0cdd0d936 media: rc: introduce BPF_PROG_LIRC_MODE2

:::::: TO: Sean Young <sean@mess.org>
:::::: CC: Daniel Borkmann <daniel@iogearbox.net>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 35548 bytes --]