From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F06C3279B for ; Fri, 6 Jul 2018 08:55:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88F2723EF1 for ; Fri, 6 Jul 2018 08:55:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88F2723EF1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sysam.it Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753457AbeGFIzk (ORCPT ); Fri, 6 Jul 2018 04:55:40 -0400 Received: from ec2-18-194-220-216.eu-central-1.compute.amazonaws.com ([18.194.220.216]:48236 "EHLO sysam.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbeGFIzh (ORCPT ); Fri, 6 Jul 2018 04:55:37 -0400 Received: from localhost (localhost [127.0.0.1]) by sysam.it (Postfix) with ESMTP id E436A21B2E; Fri, 6 Jul 2018 08:55:35 +0000 (UTC) Received: from sysam.it ([127.0.0.1]) by localhost (sysam.it [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ogCdcLSpy92j; Fri, 6 Jul 2018 08:55:34 +0000 (UTC) Received: from jerusalem (host136-239-dynamic.30-79-r.retail.telecomitalia.it [79.30.239.136]) by sysam.it (Postfix) with ESMTPSA id 944C521B2D; Fri, 6 Jul 2018 08:55:34 +0000 (UTC) Date: Fri, 6 Jul 2018 10:55:34 +0200 From: Angelo Dureghello To: Krzysztof Kozlowski Cc: Vinod , Stefan Agner , dmaengine@vger.kernel.org, Dan Williams , linux-kernel@vger.kernel.org Subject: Re: [BUG] Serial/dma stall/failure after "dmaengine: fsl-edma: extract common fsl-edma code (no changes in behavior intended)" Message-ID: <20180706085533.GA5373@jerusalem> References: <20180705073552.GI22377@vkoul-mobl> <20180705081253.GA3513@jerusalem> <20180705124526.GA3620@jerusalem> <7d2bc5bc8cd01347acf1858ba816b12d@agner.ch> <20180705162308.GB3620@jerusalem> <20180706060541.GT22377@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Jul 06, 2018 at 08:16:29AM +0200, Krzysztof Kozlowski wrote: > On 6 July 2018 at 08:05, Vinod wrote: > > On 05-07-18, 18:23, Angelo Dureghello wrote: > >> Hi Stafan, > >> > >> On Thu, Jul 05, 2018 at 05:55:31PM +0200, Stefan Agner wrote: > >> > Hi Vinod, Hi Angelo, > >> > > >> > On 05.07.2018 14:45, Angelo Dureghello wrote: > >> > > Hi Vinod, > >> > > > >> > > On Thu, Jul 05, 2018 at 10:12:53AM +0200, Angelo Dureghello wrote: > >> > >> Hi Vinod, > >> > >> > >> > >> On Thu, Jul 05, 2018 at 01:05:52PM +0530, Vinod wrote: > >> > >> > On 04-07-18, 10:54, Krzysztof Kozlowski wrote: > >> > >> > > Hi, > >> > >> > > > >> > >> > > The commit 6ad069123f03bebe4315dea13d44845854ca6043 ("dmaengine: > >> > >> > > fsl-edma: extract common fsl-edma code (no changes in behavior > >> > >> > > intended)"), even though marked as no changes in behavior intended... > >> > >> > > make serial console with DMA broken after boot. The console just hangs > >> > >> > > - is not responsive even to SysRq. Usually after finishing boot - > >> > >> > > before or after login prompt. Sometimes login is allowed and then it > >> > >> > > hangs during printing dmesg. > >> > >> > > > >> > >> > > Board: Toradex Colibri VF50 (NXP VF500, Cortex A5, serial configured > >> > >> > > with DMA) on Iris Carrier. > >> > >> > > >> > >> > Angelo ? > >> > >> > > >> > >> sorry for this. As said i couldn't test it in any of those arm boards > >> > >> but i take a look. > >> > >> > >> > >> The only code part that changes is the initial setting up of the registers. > >> > >> I am checking that. > >> > >> > >> > >> Regards, > >> > >> Angelo > >> > >> > >> > > > >> > > I cannot find anything obviously wrong. > >> > > And i cannot test on Vybrid. > >> > > I will try to get a Vybrid V50 board to test this issue. It would > >> > > require some days and also i wil be 3 weeks off on July. > >> > > > >> > > So please revert my patch. > >> > > >> > I did not found the issue quickly. But I must say that I gave up pretty > >> > quickly. There are too many changes in a single patch which makes it > >> > hard to figure out what could be wrong. I'd rather prefer if we could > >> > drop that patch again and go through another review phase. > >> > > >> > Angelo, as far as I can see the patch has not been sent to LKML or the > >> > ARM mailing list. Especially since you do not have such a device it > >> > would have been nice to also send it to the ARM mailing list... > >> > > >> > Can you resend your last revision with CC to me/ARM mailing list? > >> > > >> > >> Thanks for looking into it. > >> > >> I have spent a lot of time on this patch and really would have > >> dma for Coldfire available. So, have ordered a Colibri / v50 board. > >> > >> Should receive it in few days and should be able to debug this issue, > >> but as said, i will be off for some weeks so looks like it is probably > >> better to revert the patch. > >> > >> My initial submit was a separate driver, to avoid such issues where > >> i cannot test, but it resulted in too much duplicated code. > >> > >> Sure, i can send the full patch to you/arm with all the fixes included > >> until now. > > > > Okay dropped now from -next. I still keeping topic/fsl around and > > collect other fixes for you guys to check. > > > > One way would be to split to common patch into multiple patch and check > > regression. That should help quickly identify the issue. > > Even with show -C20% -M20% I gave up when trying to spot possible > differences in the commit. I understand that logically it is one > change and it makes sense... but it touches, moves and adds too much > making review extremely difficult. I think the splitting into smaller > chunks would be beneficial anyway. > > Today's next boots fine. > Good, will resend the patch once splitted in more commits, and tested on V50 Vybrid. Regards, Angelo > Best regards, > Krzysztof > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html