From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E7BC3279B for ; Fri, 6 Jul 2018 15:30:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D20F423F9F for ; Fri, 6 Jul 2018 15:30:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D20F423F9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754108AbeGFPae (ORCPT ); Fri, 6 Jul 2018 11:30:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35102 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753900AbeGFPad (ORCPT ); Fri, 6 Jul 2018 11:30:33 -0400 Received: from localhost (unknown [37.170.89.196]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 10F1049F; Fri, 6 Jul 2018 15:30:31 +0000 (UTC) Date: Fri, 6 Jul 2018 17:30:28 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] device: Add #define dev_fmt similar to #define pr_fmt Message-ID: <20180706153028.GA6838@kroah.com> References: <3f213f4f9ee604c1797af67360d8da1836b34271.1525878372.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f213f4f9ee604c1797af67360d8da1836b34271.1525878372.git.joe@perches.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 09, 2018 at 08:15:46AM -0700, Joe Perches wrote: > Add a prefixing macro to dev_ uses similar to the pr_fmt > prefixing macro used in pr_ calls. > > This can help avoid some string duplication in dev_ uses. > > The default, like pr_fmt, is an empty #define dev_fmt(fmt) fmt > > Rename the existing dev_ functions to _dev_ and > introduce #define dev_ _dev_ macros that use the > new #define dev_fmt > > Miscellanea: > > o Consistently use #defines with fmt, ... and ##__VA_ARGS__ > o Remove unnecessary externs SHouldn't these be separate patches please? > Signed-off-by: Joe Perches > --- > drivers/base/core.c | 12 +++--- > include/linux/device.h | 103 ++++++++++++++++++++++++++++--------------------- > 2 files changed, 64 insertions(+), 51 deletions(-) Ok this seems like a lot of churn for no real apparent gain. What is all of this getting us? What is the benifit, you have more code now, why is that good? confused, greg k-h