* [PATCH] arm64: add ARM64-specific support for flatmem
@ 2018-07-06 15:56 Nikunj Kela
2018-07-06 16:00 ` Will Deacon
0 siblings, 1 reply; 3+ messages in thread
From: Nikunj Kela @ 2018-07-06 15:56 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon; +Cc: xe-kernel, linux-arm-kernel, linux-kernel
Cc: xe-kernel@external.cisco.com
Cc: Nikunj Kela <nkela@cisco.com>
Signed-off-by: Nikunj Kela <nkela@cisco.com>
---
arch/arm64/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 42c090c..5e791f0 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -775,6 +775,10 @@ config ARCH_SPARSEMEM_DEFAULT
config ARCH_SELECT_MEMORY_MODEL
def_bool ARCH_SPARSEMEM_ENABLE
+config ARCH_FLATMEM_ENABLE
+ def_bool y
+ depends on ARM64 && !NUMA
+
config HAVE_ARCH_PFN_VALID
def_bool ARCH_HAS_HOLES_MEMORYMODEL || !SPARSEMEM
--
2.10.3.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: add ARM64-specific support for flatmem
2018-07-06 15:56 [PATCH] arm64: add ARM64-specific support for flatmem Nikunj Kela
@ 2018-07-06 16:00 ` Will Deacon
2018-07-06 16:35 ` Nikunj Kela (nkela)
0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2018-07-06 16:00 UTC (permalink / raw)
To: Nikunj Kela; +Cc: Catalin Marinas, xe-kernel, linux-arm-kernel, linux-kernel
Please write a commit message for your patch.
On Fri, Jul 06, 2018 at 08:56:27AM -0700, Nikunj Kela wrote:
> Cc: xe-kernel@external.cisco.com
> Cc: Nikunj Kela <nkela@cisco.com>
> Signed-off-by: Nikunj Kela <nkela@cisco.com>
> ---
> arch/arm64/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 42c090c..5e791f0 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -775,6 +775,10 @@ config ARCH_SPARSEMEM_DEFAULT
> config ARCH_SELECT_MEMORY_MODEL
> def_bool ARCH_SPARSEMEM_ENABLE
>
> +config ARCH_FLATMEM_ENABLE
> + def_bool y
> + depends on ARM64 && !NUMA
We don't need ARM64 here. I'm also not sure about the def_bool y, this seems
like a pretty niche thing to enable.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: add ARM64-specific support for flatmem
2018-07-06 16:00 ` Will Deacon
@ 2018-07-06 16:35 ` Nikunj Kela (nkela)
0 siblings, 0 replies; 3+ messages in thread
From: Nikunj Kela (nkela) @ 2018-07-06 16:35 UTC (permalink / raw)
To: Will Deacon
Cc: Catalin Marinas, xe-kernel@external.cisco.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Will modify the patch to remove ARM64. Every other architecture kept def_bool y for it so I followed the same for ARM64 too.
Thanks,
-Nikunj
On 7/6/18, 9:00 AM, "Will Deacon" <will.deacon@arm.com> wrote:
Please write a commit message for your patch.
On Fri, Jul 06, 2018 at 08:56:27AM -0700, Nikunj Kela wrote:
> Cc: xe-kernel@external.cisco.com
> Cc: Nikunj Kela <nkela@cisco.com>
> Signed-off-by: Nikunj Kela <nkela@cisco.com>
> ---
> arch/arm64/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 42c090c..5e791f0 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -775,6 +775,10 @@ config ARCH_SPARSEMEM_DEFAULT
> config ARCH_SELECT_MEMORY_MODEL
> def_bool ARCH_SPARSEMEM_ENABLE
>
> +config ARCH_FLATMEM_ENABLE
> + def_bool y
> + depends on ARM64 && !NUMA
We don't need ARM64 here. I'm also not sure about the def_bool y, this seems
like a pretty niche thing to enable.
Will
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-06 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-06 15:56 [PATCH] arm64: add ARM64-specific support for flatmem Nikunj Kela
2018-07-06 16:00 ` Will Deacon
2018-07-06 16:35 ` Nikunj Kela (nkela)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox