* [PATCH] thunderbolt: fix small typo in variable name
@ 2018-06-26 23:34 nathan.d.ciobanu
2018-06-27 9:41 ` Mika Westerberg
2018-07-07 8:19 ` Lukas Wunner
0 siblings, 2 replies; 4+ messages in thread
From: nathan.d.ciobanu @ 2018-06-26 23:34 UTC (permalink / raw)
To: linux-kernel
Cc: mika.westerberg, michael.jamet, andreas.noever, Nathan Ciobanu
From: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
Fixes small variable name typo and the associated
checkpatch spelling warning
Signed-off-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
---
drivers/thunderbolt/tb_regs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
index 5d94142afda6..693b0353c3fe 100644
--- a/drivers/thunderbolt/tb_regs.h
+++ b/drivers/thunderbolt/tb_regs.h
@@ -202,7 +202,7 @@ struct tb_regs_port_header {
/* DWORD 5 */
u32 max_in_hop_id:11;
u32 max_out_hop_id:11;
- u32 __unkown4:10;
+ u32 __unknown4:10;
/* DWORD 6 */
u32 __unknown5;
/* DWORD 7 */
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] thunderbolt: fix small typo in variable name
2018-06-26 23:34 [PATCH] thunderbolt: fix small typo in variable name nathan.d.ciobanu
@ 2018-06-27 9:41 ` Mika Westerberg
2018-07-07 8:19 ` Lukas Wunner
1 sibling, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2018-06-27 9:41 UTC (permalink / raw)
To: nathan.d.ciobanu; +Cc: linux-kernel, michael.jamet, andreas.noever
On Tue, Jun 26, 2018 at 04:34:20PM -0700, nathan.d.ciobanu@linux.intel.com wrote:
> From: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
>
> Fixes small variable name typo and the associated
> checkpatch spelling warning
>
> Signed-off-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
Applied to thunderbolt.git/next, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thunderbolt: fix small typo in variable name
2018-06-26 23:34 [PATCH] thunderbolt: fix small typo in variable name nathan.d.ciobanu
2018-06-27 9:41 ` Mika Westerberg
@ 2018-07-07 8:19 ` Lukas Wunner
2018-07-07 11:09 ` Mika Westerberg
1 sibling, 1 reply; 4+ messages in thread
From: Lukas Wunner @ 2018-07-07 8:19 UTC (permalink / raw)
To: nathan.d.ciobanu
Cc: linux-kernel, mika.westerberg, michael.jamet, andreas.noever
On Tue, Jun 26, 2018 at 04:34:20PM -0700, nathan.d.ciobanu@linux.intel.com wrot> Fixes small variable name typo and the associated
> checkpatch spelling warning
>
> Signed-off-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
> ---
> drivers/thunderbolt/tb_regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
> index 5d94142afda6..693b0353c3fe 100644
> --- a/drivers/thunderbolt/tb_regs.h
> +++ b/drivers/thunderbolt/tb_regs.h
> @@ -202,7 +202,7 @@ struct tb_regs_port_header {
> /* DWORD 5 */
> u32 max_in_hop_id:11;
> u32 max_out_hop_id:11;
> - u32 __unkown4:10;
> + u32 __unknown4:10;
> /* DWORD 6 */
> u32 __unknown5;
> /* DWORD 7 */
This is not an improvement. The bitfield is marked unknown because
its meaning hasn't been reverse-engineered yet. But you work for
Intel, presumably you don't have to reverse-engineer the bitfield's
meaning because you know it or can find out about it.
So please submit a patch that changes the name to the bitfield's
actual meaning.
Thanks,
Lukas
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] thunderbolt: fix small typo in variable name
2018-07-07 8:19 ` Lukas Wunner
@ 2018-07-07 11:09 ` Mika Westerberg
0 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2018-07-07 11:09 UTC (permalink / raw)
To: Lukas Wunner
Cc: nathan.d.ciobanu, linux-kernel, michael.jamet, andreas.noever
On Sat, Jul 07, 2018 at 10:19:50AM +0200, Lukas Wunner wrote:
> On Tue, Jun 26, 2018 at 04:34:20PM -0700, nathan.d.ciobanu@linux.intel.com wrot> Fixes small variable name typo and the associated
> > checkpatch spelling warning
> >
> > Signed-off-by: Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>
> > ---
> > drivers/thunderbolt/tb_regs.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thunderbolt/tb_regs.h b/drivers/thunderbolt/tb_regs.h
> > index 5d94142afda6..693b0353c3fe 100644
> > --- a/drivers/thunderbolt/tb_regs.h
> > +++ b/drivers/thunderbolt/tb_regs.h
> > @@ -202,7 +202,7 @@ struct tb_regs_port_header {
> > /* DWORD 5 */
> > u32 max_in_hop_id:11;
> > u32 max_out_hop_id:11;
> > - u32 __unkown4:10;
> > + u32 __unknown4:10;
> > /* DWORD 6 */
> > u32 __unknown5;
> > /* DWORD 7 */
>
> This is not an improvement. The bitfield is marked unknown because
> its meaning hasn't been reverse-engineered yet. But you work for
> Intel, presumably you don't have to reverse-engineer the bitfield's
> meaning because you know it or can find out about it.
>
> So please submit a patch that changes the name to the bitfield's
> actual meaning.
It is an improvement since it fixes what it says (the typo). Besides the
patch is already applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-07 11:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-26 23:34 [PATCH] thunderbolt: fix small typo in variable name nathan.d.ciobanu
2018-06-27 9:41 ` Mika Westerberg
2018-07-07 8:19 ` Lukas Wunner
2018-07-07 11:09 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox