From: Jonathan Cameron <jic23@kernel.org>
To: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Xiongfeng Wang <xiongfeng.wang@linaro.org>,
nv@vosn.de, Javier Martinez Canillas <javier@dowhile0.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] IIO: st_accel_i2c.c: Use probe_new() instead of probe()
Date: Sat, 7 Jul 2018 17:34:47 +0100 [thread overview]
Message-ID: <20180707173447.56bb4d8c@archlinux> (raw)
In-Reply-To: <b990bc14d89daba5ac3b14d4b2eefb47c972d63d.1530782560.git.nikolaus.voss@loewensteinmedical.de>
On Tue, 3 Jul 2018 08:06:57 +0200
Nikolaus Voss <nikolaus.voss@loewensteinmedical.de> wrote:
> struct i2c_device_id argument of probe() is not used, so use probe_new()
> instead.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/accel/st_accel_i2c.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/accel/st_accel_i2c.c b/drivers/iio/accel/st_accel_i2c.c
> index d02298f0256c..2ca5d1f6ade0 100644
> --- a/drivers/iio/accel/st_accel_i2c.c
> +++ b/drivers/iio/accel/st_accel_i2c.c
> @@ -139,8 +139,7 @@ static const struct i2c_device_id st_accel_id_table[] = {
> };
> MODULE_DEVICE_TABLE(i2c, st_accel_id_table);
>
> -static int st_accel_i2c_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int st_accel_i2c_probe(struct i2c_client *client)
> {
> struct iio_dev *indio_dev;
> struct st_sensor_data *adata;
> @@ -179,7 +178,7 @@ static struct i2c_driver st_accel_driver = {
> .of_match_table = of_match_ptr(st_accel_of_match),
> .acpi_match_table = ACPI_PTR(st_accel_acpi_match),
> },
> - .probe = st_accel_i2c_probe,
> + .probe_new = st_accel_i2c_probe,
> .remove = st_accel_i2c_remove,
> .id_table = st_accel_id_table,
> };
prev parent reply other threads:[~2018-07-07 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 9:22 [PATCH v4 0/2] IIO: st_sensors_i2c: improve device enumeration Nikolaus Voss
2018-07-03 5:41 ` [PATCH v4 1/2] IIO: st_accel_i2c.c: Simplify access to driver data Nikolaus Voss
2018-07-07 16:34 ` Jonathan Cameron
2018-07-03 6:06 ` [PATCH v4 2/2] IIO: st_accel_i2c.c: Use probe_new() instead of probe() Nikolaus Voss
2018-07-07 16:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180707173447.56bb4d8c@archlinux \
--to=jic23@kernel.org \
--cc=javier@dowhile0.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=nikolaus.voss@loewensteinmedical.de \
--cc=nv@vosn.de \
--cc=pmeerw@pmeerw.net \
--cc=xiongfeng.wang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox