public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Rob Herring <robh@kernel.org>, Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Peter Robinson <pbrobinson@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] driver core: add a debugfs entry to show deferred devices
Date: Sun, 8 Jul 2018 15:19:50 +0200	[thread overview]
Message-ID: <20180708131950.GA25366@kroah.com> (raw)
In-Reply-To: <bd34c19a-e673-4ce4-e57a-14cc275ab020@redhat.com>

On Sun, Jul 08, 2018 at 02:31:49AM +0200, Javier Martinez Canillas wrote:
> Hi Greg,
> 
> On 07/07/2018 05:59 PM, Greg Kroah-Hartman wrote:
> > On Thu, Jun 28, 2018 at 12:06:56AM +0200, Javier Martinez Canillas wrote:
> >> With Device Trees (DT), the dependencies of the devices are defined in the
> >> DT, then the drivers parse that information to lookup the needed resources
> >> that have as dependencies.
> >>
> >> Since drivers and devices are registered in a non-deterministic way, it is
> >> possible that a device that is a dependency has not been registered yet by
> >> the time that is looked up.
> >>
> >> In this case the driver that requires this dependency cannot probe and has
> >> to defer it. So the driver core adds it to a list of deferred devices that
> >> is iterated again every time that a new driver is probed successfully.
> >>
> >> For debugging purposes it may be useful to know what are the devices whose
> >> probe function was deferred. Add a debugfs entry showing that information.
> >>
> >>   $ cat /sys/kernel/debug/devices_deferred
> >>   48070000.i2c:twl@48:bci
> >>   musb-hdrc.0.auto
> >>   omapdrm.0
> >>
> >> This information could be obtained partially by enabling debugging, but it
> >> means that the kernel log has to be parsed and the probe deferral balanced
> >> with the successes. This can be error probe and has to be done in a ad-hoc
> >> manner by everyone who needs to debug these kind of issues.
> >>
> >> Since the information is already known by the kernel, just show it to make
> >> it easier to debug.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> >> Reviewed-by: Mark Brown <broonie@kernel.org>
> > 
> > This doesn't apply to my tree anymore :(
> >
> 
> I see, I made sure that it applied on top of linux-next.
>  
> > Can you rebase and resend?
> >
> 
> I guess you want me to rebase on top of your driver-core-next branch. I think
> that linux-next should pull that branch instead of the driver-core-linus one:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Next/Trees#n29

Both are in linux-next, it just takes a day or so for the
driver-core-next branch to get merged in.

thanks,

greg k-h

      reply	other threads:[~2018-07-08 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27 22:06 [PATCH v2] driver core: add a debugfs entry to show deferred devices Javier Martinez Canillas
2018-06-27 22:23 ` Andy Shevchenko
2018-06-28 10:14 ` Mark Brown
2018-07-07 15:59 ` Greg Kroah-Hartman
2018-07-08  0:31   ` Javier Martinez Canillas
2018-07-08 13:19     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180708131950.GA25366@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=javierm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbrobinson@gmail.com \
    --cc=robh@kernel.org \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox