From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D35D6C3279B for ; Sun, 8 Jul 2018 14:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81174208D8 for ; Sun, 8 Jul 2018 14:17:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mYLip6R+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81174208D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199AbeGHORZ (ORCPT ); Sun, 8 Jul 2018 10:17:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752750AbeGHORY (ORCPT ); Sun, 8 Jul 2018 10:17:24 -0400 Received: from localhost.localdomain (unknown [49.77.239.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BA05C208AF; Sun, 8 Jul 2018 14:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1531059443; bh=3DTynCQ/2JcVtDy4vZBvXqeMdDL1r8k15jXSqoeZDGQ=; h=From:To:Cc:Subject:Date:From; b=mYLip6R+iq5Mot4dnbZaqGNKNAp3Wl5/o4B27XAhqk1zaDKRGFX3gQFdm5Wx1ghte ie9TRL3E7KVEXQTPitc6mqXJP7bcrZyMhLCwXDoY/Bdh+kfjx4+SyXuB7eAVf3IfXC sRuhP5NoZqoFCKKsxnCOYKd/mlsvpCS18Bj3kkqg= From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Subject: [PATCH 1/5] f2fs: detect bug_on in f2fs_wait_discard_bios Date: Sun, 8 Jul 2018 22:16:53 +0800 Message-Id: <20180708141657.24641-1-chao@kernel.org> X-Mailer: git-send-email 2.16.2.17.g38e79b1fd Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu Add bug_on to detect potential non-empty discard wait list. Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index cbf8f3f9a8e7..e55188975fcc 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1495,6 +1495,8 @@ bool f2fs_wait_discard_bios(struct f2fs_sb_info *sbi) /* just to make sure there is no pending discard commands */ __wait_all_discard_cmd(sbi, NULL); + + f2fs_bug_on(sbi, atomic_read(&dcc->discard_cmd_cnt)); return dropped; } -- 2.16.2.17.g38e79b1fd