public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Janani Sankara Babu <jananis37@gmail.com>
Cc: keescook@chromium.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:fwserial Move LINUX_VENDOR_ID to firewire.h
Date: Mon, 9 Jul 2018 09:01:45 +0200	[thread overview]
Message-ID: <20180709070145.GA13285@kroah.com> (raw)
In-Reply-To: <1531151550-4918-1-git-send-email-jananis37@gmail.com>

On Mon, Jul 09, 2018 at 11:52:30AM -0400, Janani Sankara Babu wrote:
> This driver uses the same unregistered vendor id that the
> firewire core does (0xd00d1e). Hence it is exposed as a
> define in firewire.h.
> 
> Signed-off-by:Janani Sankara Babu <jananis37@gmail.com>
> ---
>  drivers/staging/fwserial/fwserial.c | 1 -
>  include/linux/firewire.h            | 2 ++
>  2 files changed, 2 insertions(+), 1 deletion(-)


staging drivers are supposed to be self-contained.  Please work to get
the fwserial driver out of the staging directory before adding stuff
like this to a .h file that everyone includes.

thanks,

greg k-h

      reply	other threads:[~2018-07-09  7:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 15:52 [PATCH] Staging:fwserial Move LINUX_VENDOR_ID to firewire.h Janani Sankara Babu
2018-07-09  7:01 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709070145.GA13285@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=jananis37@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox