Re: [PATCH] Staging: gdm724x: gdm_tty.c:Fixed Macro argument reuse

[Dan Carpenter <dan.carpenter@oracle.com>]

On Mon, Jul 09, 2018 at 03:30:20PM +0530, Jaya Durga wrote:
> From: root <root@boss.chennai.cdac.in>

Please send the patch to yourself first and make sure it's right.  Then
resend to the list.

> 
> CHECK: Macro argument reuse 'gdm' - possible side-effects?
> 
> convert GDM_TTY_READY to gdm_tty_ready static function
> to fix checkpath check
> 
> Signed-off-by: Jaya Durga <rjdurga@gmail.com>
> ---
>  drivers/staging/gdm724x/gdm_tty.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> index bf554f7c56ca..5de1940c1f79 100644
> --- a/drivers/staging/gdm724x/gdm_tty.c
> +++ b/drivers/staging/gdm724x/gdm_tty.c
> @@ -27,7 +27,11 @@
> #define MUX_TX_MAX_SIZE 2048
> -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
> +static unsigned int gdm_tty_ready(struct gdm *gdm)
> +{
> +return (gdm && gdm->tty_dev && gdm->port.count);


This needs to be indented.


regards,
dan carpenter