From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1133C5CFEB for ; Mon, 9 Jul 2018 16:01:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78AD920877 for ; Mon, 9 Jul 2018 16:01:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PsR+oc3G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78AD920877 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933855AbeGIQBs (ORCPT ); Mon, 9 Jul 2018 12:01:48 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:46722 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933360AbeGIQBd (ORCPT ); Mon, 9 Jul 2018 12:01:33 -0400 Received: by mail-pg1-f196.google.com with SMTP id p23-v6so1198114pgv.13 for ; Mon, 09 Jul 2018 09:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QW038reX92Lsz8+CJZqe0Bwb3d4HWRg1zlgouOa3RPE=; b=PsR+oc3GDl/47cRMXmVsbWMY8k/NeazAKitjvNj+ERNqCPX+1DSiY/FgmQOtGrE0bS 5Q9zr5WG/UDWmzwl4QTfMSk/9fMCRDkqna5kmWioiv1CLgJrdgZxIT31WMcTgmYpYi18 +FndJrRPXuEpOundLTxDe9Phs6A4nLp5aPH1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QW038reX92Lsz8+CJZqe0Bwb3d4HWRg1zlgouOa3RPE=; b=YnLw12m98P0kc32/PSOZyACOIzREFtXpIFaSN2eBrVKENVUysZasMBy805MfbtTwIS JwuXzHHdowEpomaKPlUDjuY4ukDduahKMfj5hzl4YwfuYVqm+ddMG2yUWH0IvLpk0xil 9T39E2UcN0a7eur5p2M5TFEWMhaSRX/d7Grj9qeQNjvW5URq6ZipHlYy9G8Nn3qemhzG GO8gF73GlSnfvaZ8WSFr18CDae82xCx8nunJX1u/Q1qY+wUn232IkBR2VD9da7oee/xc BT7hJ3IWIVgvFmRu+sg1JOBH98IGy89sc9l3kCsLn6Sl5Iu8pVOLzcq0pOHe4jenjYAS 6jHQ== X-Gm-Message-State: APt69E0WzwU/ETd6WQ/IXNcv9eaaN/Q0JCk2V7ziT9R2wJsj4q7mSky2 fGT8UHK7CKxxgZTob4Km4W0ryA== X-Google-Smtp-Source: AAOMgpeX8LsCwFTu5cZ/BtJDK+eaR+WMk5ErJyPFroYGaf3iYcnk2IrVVNiSl02IQdUDC7cd+sMLEg== X-Received: by 2002:a62:9bc5:: with SMTP id e66-v6mr21734203pfk.84.1531152092778; Mon, 09 Jul 2018 09:01:32 -0700 (PDT) Received: from localhost ([2620:0:1000:1501:8e2d:4727:1211:622]) by smtp.gmail.com with ESMTPSA id j27-v6sm45899016pfe.48.2018.07.09.09.01.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Jul 2018 09:01:32 -0700 (PDT) Date: Mon, 9 Jul 2018 09:01:31 -0700 From: Matthias Kaehlcke To: Amit Kucheria Cc: LKML , Rajendra Nayak , linux-arm-msm , Bjorn Andersson , Eduardo Valentin , smohanad@codeaurora.org, Vivek Gautam , Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , "open list:ARM/QUALCOMM SUPPORT" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , lakml , Douglas Anderson Subject: Re: [PATCH v4 6/6] arm64: dts: sdm845: Add tsens nodes Message-ID: <20180709160131.GM129942@google.com> References: <20180703214822.GD129942@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 09, 2018 at 04:56:51PM +0530, Amit Kucheria wrote: > On Wed, Jul 4, 2018 at 3:18 AM, Matthias Kaehlcke wrote: > > Hi, > > > > On Mon, Jul 02, 2018 at 06:14:09PM +0530, Amit Kucheria wrote: > >> SDM845 has two tsens blocks, one with 13 sensors and the other with 8 > >> sensors. > >> > >> Signed-off-by: Amit Kucheria > >> --- > >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 16 ++++++++++++++++ > >> 1 file changed, 16 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > >> index cdaabeb..edf8505 100644 > >> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > >> @@ -221,6 +221,22 @@ > >> #interrupt-cells = <2>; > >> }; > >> > >> + tsens0: tsens@c222000 { > >> + compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2"; > >> + reg = <0xc263000 0x1ff>, /* TM */ > >> + <0xc222000 0x1ff>; /* SROT */ > >> + #qcom,sensors = <13>; > >> + #thermal-sensor-cells = <1>; > >> + }; > >> + > >> + tsens1: tsens@c223000 { > >> + compatible = "qcom,tsens-v2.4.0", "qcom,tsens-v2"; > >> + reg = <0xc265000 0x1ff>, /* TM */ > >> + <0xc223000 0x1ff>; /* SROT */ > >> + #qcom,sensors = <8>; > >> + #thermal-sensor-cells = <1>; > >> + }; > >> + > >> spmi_bus: spmi@c440000 { > >> compatible = "qcom,spmi-pmic-arb"; > >> reg = <0xc440000 0x1100>, > > > > I tested this series on an SDM845 board. Temperatures can be read from > > the tsens0 sensors, however for tsens1 sensors I get: > > > > cat temp > > cat: temp: No data available > > > > TRDY_READY_BIT set when reading TRDY_OFFSET in get_temp_tsens_v2(). > > Unfortunately I currently have no documentation of the registers or the > > thermal sensors in general and couldn't investigate further. > > > > Any idea what could be the problem? > > Strangely enough, I'm seeing this now after rebuilding my integration > branch to test some other bits. > > I've sent another version with this patch removed while I investigate > this. Could you check if you're able to read all 8 sensors with v5? With v6 all sensors can be read, thanks!