public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Tobin C. Harding" <me@tobin.cc>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, Petr Mladek <pmladek@suse.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Theodore Ts'o <tytso@mit.edu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vsprintf: fix build warning
Date: Tue, 10 Jul 2018 09:15:28 +1000	[thread overview]
Message-ID: <20180709231528.GF4447@eros> (raw)
In-Reply-To: <20180706114951.6e739180@gandalf.local.home>

On Fri, Jul 06, 2018 at 11:49:51AM -0400, Steven Rostedt wrote:
> On Fri, 6 Jul 2018 23:42:13 +0900
> Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
> 
> > On (07/06/18 15:47), Arnd Bergmann wrote:
> > [..]
> > > Fixes: bfe80ed3d7c7 ("vsprintf: add command line option debug_boot_weak_hash")  
> > 
> > Seems like this one is still in linux-next.
> > Can we squash this patch and bfe80ed3d7c7?
> > 
> 
> I prefer not to do squashes unless absolutely necessary. Yes, it is in
> next, but even branches pulled into next should try to resist rebasing
> (I never rebase my next branch unless there is a real bug that will
> break bisecting).

So this seems to be my fault.  I was under the impression that next
branches were rebased.  This warning was introduced in v7 of my patch
set applied by Ted to his random tree.  The build warning issue was
found by the kbuild test bot and based on my _incorrect_ understanding
of how linux-next worked I implemented the fix and _incremented_ the
version number of the original patch set thinking Ted would rebase
random-next and apply the latest version.

I now see that I should have done a new patch set on top of
random-next.  Thanks for fixing this Arnd, it helped me notice that the
other code changes in the final version of that patch set didn't make it
in :)

thanks,
Tobin.

  parent reply	other threads:[~2018-07-09 23:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 13:47 [PATCH] vsprintf: fix build warning Arnd Bergmann
2018-07-06 14:42 ` Sergey Senozhatsky
2018-07-06 15:49   ` Steven Rostedt
2018-07-09  9:45     ` Petr Mladek
2018-07-09 23:15     ` Tobin C. Harding [this message]
2018-07-09 23:42     ` Tobin C. Harding
2018-07-10  0:05       ` Sergey Senozhatsky
2018-07-10  2:27       ` Steven Rostedt
2018-07-10  2:28       ` valdis.kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709231528.GF4447@eros \
    --to=me@tobin.cc \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox