From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Petr Mladek <pmladek@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] vsprintf: fix build warning
Date: Tue, 10 Jul 2018 09:05:24 +0900 [thread overview]
Message-ID: <20180710000524.GA6759@jagdpanzerIV> (raw)
In-Reply-To: <20180709234203.GG4447@eros>
On (07/10/18 09:42), Tobin C. Harding wrote:
> > I prefer not to do squashes unless absolutely necessary. Yes, it is in
> > next, but even branches pulled into next should try to resist rebasing
> > (I never rebase my next branch unless there is a real bug that will
> > break bisecting).
>
> Steve if you do not rebase your next branch and the branch ends up
> containing fixes to patches like the above doesn't this mean that when
> you do a pull request to Linus the branch you are asking to be pulled
> will be too 'dirty' i.e. I thought that the pull request should be like
> a patch set and only contain the 'final product' not every change that
> was made during development?
+1
-ss
next prev parent reply other threads:[~2018-07-10 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 13:47 [PATCH] vsprintf: fix build warning Arnd Bergmann
2018-07-06 14:42 ` Sergey Senozhatsky
2018-07-06 15:49 ` Steven Rostedt
2018-07-09 9:45 ` Petr Mladek
2018-07-09 23:15 ` Tobin C. Harding
2018-07-09 23:42 ` Tobin C. Harding
2018-07-10 0:05 ` Sergey Senozhatsky [this message]
2018-07-10 2:27 ` Steven Rostedt
2018-07-10 2:28 ` valdis.kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710000524.GA6759@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox