From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F275C3279B for ; Wed, 11 Jul 2018 02:45:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F929208EB for ; Wed, 11 Jul 2018 02:45:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="d6/fTRxl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F929208EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732455AbeGKCrW (ORCPT ); Tue, 10 Jul 2018 22:47:22 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:34907 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732292AbeGKCrW (ORCPT ); Tue, 10 Jul 2018 22:47:22 -0400 Received: by mail-pl0-f68.google.com with SMTP id k1-v6so8471279plt.2 for ; Tue, 10 Jul 2018 19:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XmhDv5gCfelaq/X6bm67Hkzu01abxm68BhQH0M+figs=; b=d6/fTRxl9VXtxDV0XKz4rjL+6Po4yAXa4Rdsaq/qrAxc1nvMts5btPqnuUFJa9Qn8x iOsg6QWmEZVmzHAwpISef80dmaRU5hagxteYJUEr+nnZL370EJigTRzM+WakS9vGh8QC 1qeH+8J4VO5Mg64g+p0lkUD7TNh4w8DSdBAeo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XmhDv5gCfelaq/X6bm67Hkzu01abxm68BhQH0M+figs=; b=WODcYOHmlu8NEIVeT/ll/qN9iLTPkhZYoXRmXmJUyGAD/LNdBbzIy6+Gpn4sSgRPnz y8khKwBmouy1RYBIxR3NdLP6vPZV89geuKqacolDR6oyhydJUwDZsDGYX5zOpCBs3X7o PezJTKWaVEcAIBGCDdGkx8GTz034a3q1cSqHbDDgHR4snUW4Hql4BNRv0BsR34GKhTpl D3KRbVE6j/abhwoOZ98N7zS0V6M9Vhudpjbm6Dg/zt4ISY69HGxyIFLt+LDJm4I2FCF0 UBPjwuyNnCbJl9HUaMvr1JDcpsE2TyMZMc9rAKC2i9pfcyoMc0xXNjnEwMIDVkZa7yDU mvvg== X-Gm-Message-State: APt69E17RRM8fpjYIxF10DWuork9lGNrxoWeobhbqZ3pHR0NrML2l7uG m9Nhm3fVRGg10o8BH2AMLGfd X-Google-Smtp-Source: AAOMgpea3eG0y9iOzSjhmAqTFvfbDU6rssDvrcutqoqGXaNWoFEsphxizlPjWXojWMDu4F1xwsDHmg== X-Received: by 2002:a17:902:8541:: with SMTP id d1-v6mr3279492plo.81.1531277120593; Tue, 10 Jul 2018 19:45:20 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2405:204:7045:d86f:b8ac:1cc3:521f:4bf8]) by smtp.gmail.com with ESMTPSA id v3-v6sm59448521pgb.54.2018.07.10.19.45.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jul 2018 19:45:19 -0700 (PDT) Date: Wed, 11 Jul 2018 08:15:02 +0530 From: Manivannan Sadhasivam To: wsa@the-dreams.de, andy.shevchenko@gmail.com, peda@axentia.se Cc: linus.walleij@linaro.org, linux-i2c@vger.kernel.org, liuwei@actions-semi.com, mp-cs@actions-semi.com, 96boards@ucrobotics.com, devicetree@vger.kernel.org, andy.shevchenko@gmail.com, daniel.thompson@linaro.org, amit.kucheria@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, hzhang@ucrobotics.com, bdong@ucrobotics.com, manivannanece23@gmail.com, thomas.liau@actions-semi.com, jeff.chen@actions-semi.com, afaerber@suse.de Subject: Re: [PATCH v4 0/6] Add Actions Semiconductor Owl S900 I2C support Message-ID: <20180711024502.GA4739@Mani-XPS-13-9360> References: <20180701172305.15663-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180701172305.15663-1-manivannan.sadhasivam@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 01, 2018 at 10:52:59PM +0530, Manivannan Sadhasivam wrote: > This patchset adds I2C controller support for Actions Semiconductor S900 SoC. > This driver has been structured in a way such that there will be only > one controller driver for the whole Owl family series (S500, S700 and > S900 SoCs). > > There are 6 I2C controllers with separate memory mapped register space. > The I2C controller can handle atmost two messages concatenated by a > repeated start via its internal address feature. Hence the driver > uses this feature for messages of length greater than 1. In those cases, > the first message of the combined message should be a `write` with maximum > message length 6 and the second message's maximum length should be 240 bytes. > > As far as the bus speed is concerned, this driver only supports > Standard (100KHz) and High speed (400KHz) for now. > > The pinctrl definitions are only available for I2C0, I2C1 and I2C2. > With the mux option available only for I2C0. > > For Bubblegum-96 board utilizing the S900 SoC, only I2C1 and I2C2 which > are exposed on the Low speed expansion connector are enabled. > > This series depends on the pinctrl patch [1] is still not merged by the > platform maintainer Andreas but it has been reviewed by the pinctrl maintainer > Linus Walleij. For the reference, I have queued up all reviewed dts patches > in my tree [2] from which Andreas is picking them for 4.19. > > For this series, since the dts patches will go through the ARM SoC tree, > Andreas will pick it up once it is reviewed. > > Thanks, > Mani > > [1] https://patchwork.kernel.org/patch/10322937/ > [2] https://git.linaro.org/people/manivannan.sadhasivam/linux.git/log/?h=s900-for-next > Hi Andy, Peter, Just a gentle ping on this v4! Thanks, Mani > Changes in v4: > > As per Andy and Peter review: > > * Used spinlock for accessing most of the register access (only parts > involved sleep/long-busy-wait has been excluded) > * Removed returning 0 and added -ENXIO if the msg_ptr not equals to > message length > * Added DIV_ROUND_UP for setting clock frequency > * Changed one non-atomic mdelay instance to usleep_range > * Moved pinctrl definition patch before dts patch > * Fixed the driver to support only 100KHz and 400KHz frequencies > > Changes in v3: > > As per Peter, Andy and Andreas review: > > * Removed owl_i2c_reset function from interrupt handler since it > involves the use of delays. > * Fixed the return path in owl_i2c_master_xfer and added a note > * Changed "base" parameter to "reg" in owl_i2c_update_reg for better > understandability > * Ordered the includes in alphabetical order > * Small changes to defines and added comma at the end of struct members > * Removed rendundant 0 assignment in owl_i2c_master_xfer > * Changed all OWL naming convention to Owl and also changed Actions Semi > naming to Actions Semiconductor > > Changes in v2: > > As per Andy's review: > * Modified infinite loops to fixed number of retries > * Used i2c_8bit_addr_from_msg for constructing the slave address > * Removed unnecessary parenthesis around defines > * Modified certain dev_warn to dev_dbg > * Modified the error handling to more generic pattern > > * Fixed the return value in owl_i2c_master_xfer > * Added MAINTAINERS patch for I2C driver and its binding > > Manivannan Sadhasivam (6): > dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C > controller > arm64: dts: actions: Add pinctrl definition for S900 I2C controller > arm64: dts: actions: Add Actions Semiconductor S900 I2C controller > nodes > arm64: dts: actions: Enable I2C1 and I2C2 in Bubblegum-96 board > i2c: Add Actions Semiconductor Owl family S900 I2C driver > MAINTAINERS: Add entry for Actions Semiconductor Owl I2C driver > > .../devicetree/bindings/i2c/i2c-owl.txt | 27 + > MAINTAINERS | 2 + > .../dts/actions/s900-bubblegum-96-pins.dtsi | 29 + > .../boot/dts/actions/s900-bubblegum-96.dts | 11 + > arch/arm64/boot/dts/actions/s900.dtsi | 60 +++ > drivers/i2c/busses/Kconfig | 7 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-owl.c | 504 ++++++++++++++++++ > 8 files changed, 641 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt > create mode 100644 arch/arm64/boot/dts/actions/s900-bubblegum-96-pins.dtsi > create mode 100644 drivers/i2c/busses/i2c-owl.c > > -- > 2.17.1 >