From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13175C43A1D for ; Thu, 12 Jul 2018 12:26:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B466C208E9 for ; Thu, 12 Jul 2018 12:26:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="UNgUyHAF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B466C208E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727642AbeGLMgL (ORCPT ); Thu, 12 Jul 2018 08:36:11 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37218 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbeGLMgK (ORCPT ); Thu, 12 Jul 2018 08:36:10 -0400 Received: by mail-wm0-f67.google.com with SMTP id n17-v6so5860565wmh.2 for ; Thu, 12 Jul 2018 05:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Xo1D7zw6ZtaNyAkaHreMqFBi7XKPoPT644sdcodOMiY=; b=UNgUyHAFaZmTs4FldA8B3b8exzTYORAryxoP3N2Z5RTOjzh1LxBLBw0junjI7QeSyq ij4T7yiWscMDtKdqxXbZmo5z44/6C2IxR00Yuo15RGHY7w0P8biGD22Gji8ZjcVfA+TE FegDn3c2C4401lDKYvKq/WlDO6osiZprWZuSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Xo1D7zw6ZtaNyAkaHreMqFBi7XKPoPT644sdcodOMiY=; b=udBnYeu47hTOfXpFl9IEej4CJr0C1exf08T175dCKC+aHJew2slp1GOT4TYzDtmY6X aOtWtJ0IZpBQYdXKoQHUL4JMGiVlBOIFQ3zK9A6dQ86H0OzW9CKMydft1cEX+bNn6cZ+ aNyYsRu6iK7cZvvP2KEU4eTrCkzcQHkZ1Tcmina9LSQwZvd2UKAMHHaV2ATFDysQvdpg vJ7WVNJsPsQk04GbMI0voh24KMCxp0XpnETooEa2UmkrDRMJpeSMuOOwsBLCnYrbo+YZ UbCndwpHQzrJw6KfBgJCcqOAfx1TUM8gysN2CaOAOleMmiAzDG+jAeX808YE4L2gORMq nlQA== X-Gm-Message-State: AOUpUlH3DdENL/My6IcaWrvlFwyfAWwQoINtUd9Q2hQnQMxw3yDhCZcU ncuQ8U5nUFUINBHHTtfD36yhEA== X-Google-Smtp-Source: AAOMgpdQffpEczZNEX/UFTscGwCIf4Ts7Ftp0DNsKIFWwNVL7LUP1UZRpfMSkG008f/5WMMn5BaVjw== X-Received: by 2002:a1c:ae8b:: with SMTP id x133-v6mr1318100wme.125.1531398407524; Thu, 12 Jul 2018 05:26:47 -0700 (PDT) Received: from dell ([2.27.167.87]) by smtp.gmail.com with ESMTPSA id u11-v6sm1691816wmf.28.2018.07.12.05.26.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 12 Jul 2018 05:26:46 -0700 (PDT) Date: Thu, 12 Jul 2018 13:26:45 +0100 From: Lee Jones To: Neil Armstrong Cc: airlied@linux.ie, hans.verkuil@cisco.com, olof@lixom.net, seanpaul@google.com, sadolfsson@google.com, felixe@google.com, bleung@google.com, darekm@google.com, marcheu@chromium.org, fparent@baylibre.com, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, eballetbo@gmail.com Subject: Re: [PATCH v8 0/6] Add ChromeOS EC CEC Support Message-ID: <20180712122645.GE4641@dell> References: <1530716901-30164-1-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1530716901-30164-1-git-send-email-narmstrong@baylibre.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Jul 2018, Neil Armstrong wrote: > Hi All, > > The new Google "Fizz" Intel-based ChromeOS device is gaining CEC support > through it's Embedded Controller, to enable the Linux CEC Core to communicate > with it and get the CEC Physical Address from the correct HDMI Connector, the > following must be added/changed: > - Add the CEC sub-device registration in the ChromeOS EC MFD Driver > - Add the CEC related commands and events definitions into the EC MFD driver > - Add a way to get a CEC notifier with it's (optional) connector name > - Add the CEC notifier to the i915 HDMI driver > - Add the proper ChromeOS EC CEC Driver > > The CEC notifier with the connector name is the tricky point, since even on > Device-Tree platforms, there is no way to distinguish between multiple HDMI > connectors from the same DRM driver. The solution I implemented is pretty > simple and only adds an optional connector name to eventually distinguish > an HDMI connector notifier from another if they share the same device. > > Feel free to comment this patchset ! > > Changes since v7: > - rebased on v4.18-rc1 > - Fixed whitespace issues on patch 3 > - Added Lee's tags > > Changes since v6: > - Added stable identifier comment in intel_display.h > - Renamed to cec_notifier in intel_hdmi.c/intel_drv.h > - Added Acked-by/Reviewed-By tags > > Changes since v5: > - Small fixups on include/linux/mfd/cros_ec_commands.h > - Fixed on cros-ec-cec driver accordingly > - Added Reviewed-By tags > > Changes since v4: > - Split patch 3 to move the mkbp event size change into a separate patch > > Changes since v3 (incorrectly reported as v2): > - Renamed "Chrome OS" to "ChromeOS" > - Updated cros_ec_commands.h new structs definitions to kernel doc format > - Added Reviewed-By tags > > Changes since v2: > - Add i915 port_identifier() and use this stable name as cec_notifier conn name > - Fixed and cleaned up the CEC commands and events handling > - Rebased the CEC sub-device registration on top of Enric's serie > - Fixed comments typo on cec driver > - Protected the DMI match only with PCI and DMI Kconfigs > > Changes since v1: > - Added cec_notifier_put to intel_hdmi > - Fixed all small reported issues on the EC CEC driver > - Moved the cec_notifier_get out of the #if .. #else .. #endif > > Changes since RFC: > - Moved CEC sub-device registration after CEC commands and events definitions patch > - Removed get_notifier_get_byname > - Added CEC_CORE select into i915 Kconfig > - Removed CEC driver fallback if notifier is not configured on HW, added explicit warn > - Fixed CEC core return type on error > - Moved to cros-ec-cec media platform directory > - Use bus_find_device() to find the pci i915 device instead of get_notifier_get_byname() > - Fix Logical Address setup > - Added comment about HW support > - Removed memset of msg structures > > Neil Armstrong (6): > media: cec-notifier: Get notifier by device and connector name > drm/i915: hdmi: add CEC notifier to intel_hdmi > mfd: cros-ec: Increase maximum mkbp event size > mfd: cros-ec: Introduce CEC commands and events definitions. > mfd: cros_ec_dev: Add CEC sub-device registration > media: platform: Add ChromeOS EC CEC driver > > drivers/gpu/drm/i915/Kconfig | 1 + > drivers/gpu/drm/i915/intel_display.h | 24 ++ > drivers/gpu/drm/i915/intel_drv.h | 2 + > drivers/gpu/drm/i915/intel_hdmi.c | 13 + > drivers/media/cec/cec-notifier.c | 11 +- > drivers/media/platform/Kconfig | 11 + > drivers/media/platform/Makefile | 2 + > drivers/media/platform/cros-ec-cec/Makefile | 1 + > drivers/media/platform/cros-ec-cec/cros-ec-cec.c | 347 +++++++++++++++++++++++ > drivers/mfd/cros_ec_dev.c | 16 ++ > drivers/platform/chrome/cros_ec_proto.c | 40 ++- > include/linux/mfd/cros_ec.h | 2 +- > include/linux/mfd/cros_ec_commands.h | 97 +++++++ > include/media/cec-notifier.h | 27 +- > 14 files changed, 578 insertions(+), 16 deletions(-) > create mode 100644 drivers/media/platform/cros-ec-cec/Makefile > create mode 100644 drivers/media/platform/cros-ec-cec/cros-ec-cec.c How would you like to handle this set? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog