From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 843C9EB0BDC for ; Thu, 12 Jul 2018 18:17:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EE72213A2 for ; Thu, 12 Jul 2018 18:17:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EE72213A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbeGLS2L (ORCPT ); Thu, 12 Jul 2018 14:28:11 -0400 Received: from mail.bootlin.com ([62.4.15.54]:39734 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbeGLS2L (ORCPT ); Thu, 12 Jul 2018 14:28:11 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 4234D20798; Thu, 12 Jul 2018 20:17:28 +0200 (CEST) Received: from localhost (unknown [88.191.26.124]) by mail.bootlin.com (Postfix) with ESMTPSA id 18D1F206ED; Thu, 12 Jul 2018 20:17:18 +0200 (CEST) Date: Thu, 12 Jul 2018 20:17:18 +0200 From: Alexandre Belloni To: Colin King Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: test: make array pdev static Message-ID: <20180712181718.GG16084@piout.net> References: <20180624103803.4606-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180624103803.4606-1-colin.king@canonical.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/06/2018 11:38:03+0100, Colin King wrote: > From: Colin Ian King > > The array pdev is local to the source and does not need to be in > global scope, so make it static. > > Cleans up sparse warning: > symbol 'pdev' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/rtc/rtc-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com