From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Radu Pirea <radu.pirea@microchip.com>
Cc: Mark Brown <broonie@kernel.org>,
nicolas.ferre@microchip.com, lee.jones@linaro.org,
richard.genoud@gmail.com, robh+dt@kernel.org,
mark.rutland@arm.com, gregkh@linuxfoundation.org,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi
Date: Fri, 13 Jul 2018 12:06:33 +0200 [thread overview]
Message-ID: <20180713100633.GR16084@piout.net> (raw)
In-Reply-To: <dc410321-5dfd-7c26-2a3e-d2b2840da214@microchip.com>
On 13/07/2018 12:56:22+0300, Radu Pirea wrote:
>
>
> On 07/10/2018 09:15 PM, Mark Brown wrote:
> > On Mon, Jun 25, 2018 at 08:22:29PM +0300, Radu Pirea wrote:
> >
> > This is mostly good, just a couple of small things:
> >
> > > +config SPI_AT91_USART
> > > + tristate "Atmel USART Controller SPI driver"
> > > + depends on HAS_DMA
> > > + depends on (ARCH_AT91 || COMPILE_TEST)
> > > + select MFD_AT91_USART
> >
> > Why is this selecting rather than depending on the MFD like we normally
> > do?
> >
>
> Hi Mark,
>
> If I add depends instead of select, current defconfigs will be broken and
> the proper driver will not be selected. Like this, there is no required
> change in any defconfig. Selecting the serial or spi driver from menuconfig
> makes the MFD completely transparent.
I would say that this is true for the USART part but the SPI part can
use a depends on as it didn't exist before.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-13 10:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 17:22 [PATCH v10 0/6] Driver for at91 usart in spi mode Radu Pirea
2018-06-25 17:22 ` [PATCH v10 1/6] MAINTAINERS: add at91 usart mfd driver Radu Pirea
2018-07-04 6:23 ` Lee Jones
2018-06-25 17:22 ` [PATCH v10 2/6] dt-bindings: add binding for atmel-usart in SPI mode Radu Pirea
2018-07-04 6:23 ` Lee Jones
2018-06-25 17:22 ` [PATCH v10 3/6] mfd: at91-usart: added mfd driver for usart Radu Pirea
2018-06-25 17:22 ` [PATCH v10 4/6] MAINTAINERS: add at91 usart spi driver Radu Pirea
2018-06-25 17:22 ` [PATCH v10 5/6] spi: at91-usart: add driver for at91-usart as spi Radu Pirea
2018-07-10 18:15 ` Mark Brown
2018-07-13 9:56 ` Radu Pirea
2018-07-13 10:06 ` Alexandre Belloni [this message]
2018-06-25 17:22 ` [PATCH v10 6/6] tty/serial: atmel: change the driver to work under at91-usart mfd Radu Pirea
2018-07-11 8:26 ` [PATCH v10 0/6] Driver for at91 usart in spi mode Nicolas Ferre
2018-07-13 7:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713100633.GR16084@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=radu.pirea@microchip.com \
--cc=richard.genoud@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox