From: John Whitmore <arigead@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: John Whitmore <johnfwhitmore@gmail.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
kstewart@linuxfoundation.org, keescook@chromium.org,
aastha.gupta4104@gmail.com, pombredanne@nexb.com,
tglx@linutronix.de
Subject: Re: [PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style
Date: Fri, 13 Jul 2018 12:26:30 +0100 [thread overview]
Message-ID: <20180713112628.GA656@xux707-tw> (raw)
In-Reply-To: <20180713093938.GA19286@kroah.com>
On Fri, Jul 13, 2018 at 11:39:38AM +0200, Greg KH wrote:
> On Wed, Jul 11, 2018 at 08:21:43PM +0100, John Whitmore wrote:
> > Simple rename of the preprosessor switch, protecting against multiple
> > inclusion of the header file. Change to clear the checkpatch coding style
> > issue.
> >
> > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> > ---
> > drivers/staging/rtl8192u/r8192U.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
> > index a653a51f7b90..86cf3ef3a970 100644
> > --- a/drivers/staging/rtl8192u/r8192U.h
> > +++ b/drivers/staging/rtl8192u/r8192U.h
> > @@ -15,8 +15,8 @@
> > * project Authors.
> > */
> >
> > -#ifndef R819xU_H
> > -#define R819xU_H
> > +#ifndef R819U_H
> > +#define R819U_H
>
> Shouldn't this be R8192U_H?
>
> thanks,
>
> greg k-h
Yes definately. I had another series of minor changes ready to go, so I just
tacked this change onto the end again.
jwhitmore
next prev parent reply other threads:[~2018-07-13 11:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 19:21 [0/10] staging:rtl8192u: One significant change John Whitmore
2018-07-11 19:21 ` [PATCH 01/10] staging:rtl8192u: typedef struct tx_desc_819x_usb > struct tx_desc_819x_usb John Whitmore
2018-07-11 19:21 ` [PATCH 02/10] staging:rtl8192u: trim multiple blank lines - Coding Style John Whitmore
2018-07-11 19:21 ` [PATCH 03/10] staging:rtl8192u: remove unused structure tx_desc_819x_usb_aggr_subframe John Whitmore
2018-07-11 19:21 ` [PATCH 04/10] staging:rtl8192u: Rename file macro to avoid camel case - Coding Style John Whitmore
2018-07-13 9:39 ` Greg KH
2018-07-13 11:26 ` John Whitmore [this message]
2018-07-11 19:21 ` [PATCH 05/10] staging:rtl8192u: typedef struct tx_desc_cmd_819x_usb remove typedef John Whitmore
2018-07-11 19:21 ` [PATCH 06/10] staging:rtl8192u: typedef struct tx_fwinfo_819x_usb " John Whitmore
2018-07-11 19:21 ` [PATCH 07/10] staging:rtl8192u: typedef struct rx_desc_819x_usb " John Whitmore
2018-07-11 19:21 ` [PATCH 08/10] staging:rtl8192u: Remove struct rx_desc_819x_usb_aggr_subframe John Whitmore
2018-07-11 19:21 ` [PATCH 09/10] staging:rtl8192u: remove typedef from struct rx_drvinfo_819x_usb John Whitmore
2018-07-11 19:21 ` [PATCH 10/10] staging:rtl8192u: Change struct r8192_priv member Rf_Mode from u8 > enum John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713112628.GA656@xux707-tw \
--to=arigead@gmail.com \
--cc=aastha.gupta4104@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=keescook@chromium.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox