From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71307ECDFB1 for ; Sun, 15 Jul 2018 10:04:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 28777208D8 for ; Sun, 15 Jul 2018 10:04:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28777208D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726194AbeGOK0N (ORCPT ); Sun, 15 Jul 2018 06:26:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34742 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbeGOK0N (ORCPT ); Sun, 15 Jul 2018 06:26:13 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C38A54A3; Sun, 15 Jul 2018 10:03:47 +0000 (UTC) Date: Sun, 15 Jul 2018 12:03:45 +0200 From: Greg Kroah-Hartman To: Dmitry Torokhov Cc: devel@driverdev.osuosl.org, toddpoynor@gmail.com, frankhu@chromium.org, jnjoseph@google.com, lkml , Simon Que , rspringer@google.com, Guenter Roeck , toddpoynor@google.com Subject: Re: [PATCH 11/18] staging: gasket: always allow root open for write Message-ID: <20180715100345.GA17618@kroah.com> References: <20180714055816.223754-1-toddpoynor@gmail.com> <20180714055816.223754-12-toddpoynor@gmail.com> <20180715090544.GC23333@kroah.com> <20180715093216.GA16003@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 15, 2018 at 12:53:09PM +0300, Dmitry Torokhov wrote: > > I can't wait for people to just realize this whole "new" subsystem can > > be replaced with UIO, but that's a topic for a different thread... > > Yes, that is true and that is why I am not sure why we are going > through all this staging exercise. > > As far as I understand we'd still need to have quite a bit of kernel > code so that we can safely program DMA controller (it does not look > like uio_dmem_genirq.c is sufficient as is for gasket needs), but that > should be solvable. I agree, it should be solvable, and much smaller and simpler than this whole large chunk of "subsystem+driver" code. But I'm not the one having to do this work, and it provides a bunch of easy cleanups for people looking to get into kernel development, so I don't mind :) But the "maintainers" should keep this in mind, as it is, this code is _not_ acceptable for the main kernel tree because of the UIO framework already present. thanks, greg k-h