From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: Sebastian Reichel <sre@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net,
merlijn@wizzup.org
Subject: Re: Vibrations on Droid 4?
Date: Sun, 15 Jul 2018 22:17:29 +0200 [thread overview]
Message-ID: <20180715201729.GB19675@amd> (raw)
In-Reply-To: <20180711132739.GL99251@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1786 bytes --]
On Wed 2018-07-11 06:27:39, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [180711 08:05]:
> > Hi!
> >
> > > > Its parent is gpio@4805d000 , and that one seems to be present.
> > > >
> > > > user@devuan:/sys/bus/platform/devices$ ls 4805d000.gpio
> > > > driver driver_override gpio
> > > > gpiochip5 modalias of_node power subsystem uevent
> > >
> > > Sorry, something went wrong with merging this. The parent
> > > of ti,omap-dmtimer-pwm and pwm-vibrator should be / and
> > > not gpio6.
> >
> > Ok, got it to probe... after dts fix and adding EPROBE_DEFFER to
> > driver.
> ..
> > --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> > +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> > @@ -159,13 +159,7 @@
> >
> > dais = <&mcbsp2_port>, <&mcbsp3_port>;
> > };
> > -};
> > -
> > -&dss {
> > - status = "okay";
> > -};
> >
> > -&gpio6 {
> > pwm8: dmtimer-pwm-8 {
> > pinctrl-names = "default";
> > pinctrl-0 = <&vibrator_direction_pin>;
> > @@ -192,7 +186,10 @@
> > pwm-names = "enable", "direction";
> > direction-duty-cycle-ns = <10000000>;
> > };
> > +};
> >
> > +&dss {
> > + status = "okay";
> > };
> >
> > &dsi1 {
>
> Hmm sorry if I did a mismerge on the above. A note to
> myself to stop applying patches that apply with fuzz,
> that is clearly dangerous with dts files with lots
> of similar named properties.
Yep, so I have two patches that make the device appear, but vibrations
still do not work for me.
a) any ideas how to debug that / get them to work?
b) do you want the patches anyway?
Regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-07-15 20:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:15 Vibrations on Droid 4? Pavel Machek
2018-07-09 21:49 ` Sebastian Reichel
2018-07-09 22:02 ` Pavel Machek
2018-07-10 10:11 ` Sebastian Reichel
2018-07-10 13:30 ` Pavel Machek
2018-07-10 16:11 ` Sebastian Reichel
2018-07-11 8:02 ` Pavel Machek
2018-07-11 13:27 ` Tony Lindgren
2018-07-11 14:25 ` Sebastian Reichel
2018-07-16 7:10 ` [PATCH] dts/droid4: fix dts w.r.t. pwm Pavel Machek
2018-07-16 10:11 ` Sebastian Reichel
2018-07-17 6:48 ` Tony Lindgren
2018-07-16 7:13 ` [PATCH] pwm-omap: handle timers not ready in probe Pavel Machek
2018-07-16 7:57 ` Tony Lindgren
2018-07-16 8:37 ` Pavel Machek
2018-07-16 15:47 ` David Rivshin
2018-07-15 20:17 ` Pavel Machek [this message]
2018-07-16 7:59 ` Vibrations on Droid 4? Tony Lindgren
2018-08-01 18:58 ` Pavel Machek
2018-08-02 11:07 ` Sebastian Reichel
2018-08-08 17:09 ` Pavel Machek
2018-08-01 20:26 ` Pavel Machek
2018-08-01 20:28 ` [PATCH] fix vibrations on Droid 4 Pavel Machek
2018-08-02 10:55 ` Sebastian Reichel
2018-08-17 14:26 ` Tony Lindgren
2018-07-11 8:25 ` Vibrations on Droid 4? Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180715201729.GB19675@amd \
--to=pavel@ucw.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=mpartap@gmx.net \
--cc=nekit1000@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).