From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0793ECDFB3 for ; Mon, 16 Jul 2018 07:57:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93FC3208E9 for ; Mon, 16 Jul 2018 07:57:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93FC3208E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727530AbeGPIXv convert rfc822-to-8bit (ORCPT ); Mon, 16 Jul 2018 04:23:51 -0400 Received: from muru.com ([72.249.23.125]:51568 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726190AbeGPIXu (ORCPT ); Mon, 16 Jul 2018 04:23:50 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A37CD80EE; Mon, 16 Jul 2018 08:00:52 +0000 (UTC) Date: Mon, 16 Jul 2018 00:57:40 -0700 From: Tony Lindgren To: Pavel Machek Cc: Sebastian Reichel , kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org Subject: Re: [PATCH] pwm-omap: handle timers not ready in probe Message-ID: <20180716075740.GT99251@atomide.com> References: <20180709081534.GA6799@amd> <20180709214910.tes6u4ivxomd3aja@earth.universe> <20180709220211.GA7760@amd> <20180710101147.lyu65ro4czvrs2da@earth.universe> <20180710133040.GA4391@amd> <20180710161123.azym6sbboriuj4yc@earth.universe> <20180711080218.GA21225@amd> <20180711132739.GL99251@atomide.com> <20180711142526.dto6iost57zx5t5l@earth.universe> <20180716071323.GB23110@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20180716071323.GB23110@amd> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Machek [180716 07:16]: > > When all the drivers are built-in, timers are not ready and probing > fails. Fix that with -EPROBE_DEFFER. > > Signed-off-by: Pavel Machek > > diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c > index 665da3c..debeb70 100644 > --- a/drivers/pwm/pwm-omap-dmtimer.c > +++ b/drivers/pwm/pwm-omap-dmtimer.c > @@ -265,7 +271,7 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev) > timer_pdata = dev_get_platdata(&timer_pdev->dev); > if (!timer_pdata) { > dev_err(&pdev->dev, "dmtimer pdata structure NULL\n"); > - ret = -EINVAL; > + ret = -EPROBE_DEFER; > goto put; > } There seems to be an earlier similar patch, care to take a look at "[PATCH] pwm: pwm-omap-dmtimer: return -EPROBE_DEFER if no dmtimer platform data"? Regards, Tony