From: Greg KH <gregkh@linuxfoundation.org>
To: John Whitmore <johnfwhitmore@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
tglx@linutronix.de, kstewart@linuxfoundation.org,
pombredanne@nexb.com
Subject: Re: staging:rtl8192u: [0/10] Coding style changes.
Date: Mon, 16 Jul 2018 10:40:20 +0200 [thread overview]
Message-ID: <20180716084020.GA8260@kroah.com> (raw)
In-Reply-To: <20180713201247.21428-1-johnfwhitmore@gmail.com>
On Fri, Jul 13, 2018 at 09:12:37PM +0100, John Whitmore wrote:
> All coding style changes, but the second [2/10] is a bit more hairy then
> most. The original code combined two typedef declarations into one with both
> the structure and a pointer to the structure defined. I've totally removed the
> pointer to the structure type since it uses Hungarian notation, which the
> coding standard isn't keen on.
>
> As a result of this there are changes in code from the type:
> PStructType *ppname;
> to:
> struct StructType **ppname;
>
> To keep the diff simple I've kept the current nameing of "ppname", which again
> is Hungarian notation. I'll leave that for a future patch.
Nit, your subject should look like:
Subject: [PATCH 00/10] staging:rtl8192u: Coding style changes.
What are you using to generate this email? git format-patch
--cover-letter should generate it with a correct subject line prefix,
right?
thanks,
greg k-h
next prev parent reply other threads:[~2018-07-16 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 20:12 staging:rtl8192u: [0/10] Coding style changes John Whitmore
2018-07-13 20:12 ` [PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style John Whitmore
2018-07-16 8:41 ` Greg KH
2018-07-16 11:30 ` John Whitmore
2018-07-13 20:12 ` [PATCH 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO " John Whitmore
2018-07-16 8:42 ` Greg KH
2018-07-16 11:36 ` John Whitmore
2018-07-13 20:12 ` [PATCH 03/10] staging:rtl8192u: Rename List > list - Coding style John Whitmore
2018-07-13 20:12 ` [PATCH 04/10] staging:rtl8192u: rename SetupTimer > setup_timer - Style John Whitmore
2018-07-13 20:12 ` [PATCH 05/10] staging:rtl8192u: Rename InactTimer > inact_timer " John Whitmore
2018-07-13 20:12 ` [PATCH 06/10] staging:rtl8192u: Rename Addr > addr " John Whitmore
2018-07-13 20:12 ` [PATCH 07/10] staging:rtl8192u: Rename TSpec > t_spec " John Whitmore
2018-07-13 20:12 ` [PATCH 08/10] staging:rtl8192u: Rename TClass > t_class " John Whitmore
2018-07-13 20:12 ` [PATCH 09/10] staging:trl8192u: Rename TClasProc > t_clas_proc " John Whitmore
2018-07-13 20:12 ` [PATCH 10/10] staging:rtl8192u: Rename TClasNum > t_clas_num " John Whitmore
2018-07-16 8:40 ` Greg KH [this message]
2018-07-16 11:34 ` staging:rtl8192u: [0/10] Coding style changes John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716084020.GA8260@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=johnfwhitmore@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox