From: Greg KH <gregkh@linuxfoundation.org>
To: RAGHU Halharvi <raghuhack78@gmail.com>
Cc: devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, wsa@the-dreams.de
Subject: Re: [PATCH] staging: ks7010_sdio:Fix checkpatch out of memory warning
Date: Mon, 16 Jul 2018 12:02:30 +0200 [thread overview]
Message-ID: <20180716100230.GA30655@kroah.com> (raw)
In-Reply-To: <20180713160636.8017-1-raghuhack78@gmail.com>
On Fri, Jul 13, 2018 at 09:36:36PM +0530, RAGHU Halharvi wrote:
> * Patch fixes checkpatch warning "Possible unnecessary 'out of memory'
> message"
>
> Signed-off-by: RAGHU Halharvi <raghuhack78@gmail.com>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index b8f55a11ee1c..972b01a0257d 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -957,10 +957,8 @@ static int send_stop_request(struct sdio_func *func)
> card = sdio_get_drvdata(func);
>
> pp = kzalloc(hif_align_size(sizeof(*pp)), GFP_KERNEL);
> - if (!pp) {
> - netdev_err(card->priv->net_dev, "allocate memory failed..\n");
> + if (!pp)
> return -ENOMEM;
> - }
This change has already been done in my tree, please always work against
linux-next at the least, and ideally staging.git, so that you do not
duplicate work others have already done.
thanks,
greg k-h
prev parent reply other threads:[~2018-07-16 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 16:06 [PATCH] ks7010_sdio:Fix checkpatch out of memory warning RAGHU Halharvi
2018-07-16 10:01 ` Greg KH
2018-07-16 10:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716100230.GA30655@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raghuhack78@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox