Re: [PATCH 1/4] lib/crc64: add crc64 option to lib/Kconfig

Randy Dunlap
2018-07-16T17:49:02Z

On 07/16/2018 09:55 AM, Coly Li wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> This patch adds crc64 option entry in lib/Kconfig. This patch is part of
> a patch originally written by Andy Shevchenko, Coly Li cherry-picks it
> and compose the commit log for a re-written crc64 source code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Coly Li <colyli@suse.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Luis R. Rodriguez <mcgrof@suse.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Kate Stewart <kstewart@linuxfoundation.org>
> ---
> lib/Kconfig | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 706836ec314d..4059df9ec4c7 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -170,6 +170,14 @@ config CRC32_BIT
>
> endchoice
>
> +config CRC64
> + tristate "CRC64 functions"
> + help
> + This option is provided for the case where no in-kernel-tree
> + modules require CRC64 functions, but a module built outside
> + the kernel tree does. Such modules that use library CRC64
> + functions require M he

eh? missing something here.

> +
> config CRC4
> tristate "CRC4 functions"
> help
>

--
~Randy