From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80086ECDFB3 for ; Tue, 17 Jul 2018 01:24:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 395E720BED for ; Tue, 17 Jul 2018 01:24:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 395E720BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730873AbeGQBx6 (ORCPT ); Mon, 16 Jul 2018 21:53:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59496 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729913AbeGQBx6 (ORCPT ); Mon, 16 Jul 2018 21:53:58 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD038308402C; Tue, 17 Jul 2018 01:23:56 +0000 (UTC) Received: from rh (ovpn-116-84.phx2.redhat.com [10.3.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BD60645AA; Tue, 17 Jul 2018 01:23:55 +0000 (UTC) Received: from [::1] (helo=rh) by rh with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ffEiR-0006sE-Q2; Tue, 17 Jul 2018 11:23:47 +1000 Date: Tue, 17 Jul 2018 11:23:45 +1000 From: Dave Chinner To: Jan Stancek Cc: Naresh Kamboju , Greg Kroah-Hartman , Ben Hutchings , Linus Torvalds , ltp@lists.linux.it, open list , lkft-triage@lists.linaro.org, patches@kernelci.org, linux- stable , Andrew Morton , Shuah Khan , Guenter Roeck , linux-xfs@vger.kernel.org Subject: Re: [LTP] [PATCH 4.17 00/67] 4.17.7-stable review Message-ID: <20180717012345.GM20351@rh> References: <20180716073443.294323458@linuxfoundation.org> <2078122506.33400530.1531776704409.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2078122506.33400530.1531776704409.JavaMail.zimbra@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 17 Jul 2018 01:23:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [cc linux-xfs@vger.kernel.org] Darrick, can you have a look over this mess while I'm afk? -Dave. On Mon, Jul 16, 2018 at 05:31:44PM -0400, Jan Stancek wrote: > > > ----- Original Message ----- > > On 16 July 2018 at 13:04, Greg Kroah-Hartman > > wrote: > > > This is the start of the stable review cycle for the 4.17.7 release. > > > There are 67 patches in this series, all will be posted as a response > > > to this one. If anyone has any issues with these being applied, please > > > let me know. > > > > > > Responses should be made by Wed Jul 18 07:34:11 UTC 2018. > > > Anything received after that time might be too late. > > > > > > The whole patch series can be found in one patch at: > > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.17.7-rc1.gz > > > or in the git tree and branch at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > linux-4.17.y > > > and the diffstat can be found below. > > > > > > thanks, > > > > > > greg k-h > > > > > > Results from Linaro’s test farm. > > Regressions detected. > > > > LTP syscalls failed test cases on all devices arm64, arm32 and x86_64, > > - creat08 > > - open10 > > This is consequence of: > 0fa3ecd87848 ("Fix up non-directory creation in SGID directories") > > So likely cause of action here will be modifying both tests to not > expect S_ISGID in scenario described in commit above. > > [adding Dave Chinner] > > @Dave: Does XFS need separate patch for problem described in commit > 0fa3ecd87848? XFS doesn't appear to use inode_init_owner() function, > both tests currently PASS the check for S_ISGID on file created by > non-group member as of v4.18-rc5. > > Regards, > Jan > > > > > Reported this bug internally on upstream Linux mainline week back. > > Now this bug happening on 4.17, 4.14, 4.9 and 4.4 > > > > creat08 and open10 failed with this error, > > TFAIL : testdir.B.3132/setgid: Incorrect modes, setgid bit should be set > > > > Test case description: > > /* > > * NAME > > * creat08.c - Verifies that the group ID and setgid bit are > > * set correctly when a new file is created. > > * (ported from SPIE, section2/iosuite/creat5.c, > > * by Airong Zhang ) > > * CALLS > > * creat > > * > > * ALGORITHM > > * Create two directories, one with the group ID of this process > > * and the setgid bit not set, and the other with a group ID > > * other than that of this process and with the setgid bit set. > > * In each directory, create a file with and without the setgid > > * bit set in the creation modes. Verify that the modes and group > > * ID are correct on each of the 4 files. > > * As root, create a file with the setgid bit on in the > > * directory with the setgid bit. > > * This tests the SVID3 create group semantics. > > */ > > > > Block2 testing: > > /*--------------------------------------------------------------*/ > > /* Block2: Create two files in testdir.B, one with the setgid */ > > /* bit set in the creation modes and the other without. */ > > /* Both should inherit the group ID of the parent */ > > /* directory, group2. */ > > /*--------------------------------------------------------------*/ > > > > > > Test results comparison on mainline versions, > > https://qa-reports.linaro.org/lkft/linux-mainline-oe/tests/ltp-syscalls-tests/creat08 > > https://qa-reports.linaro.org/lkft/linux-mainline-oe/tests/ltp-syscalls-tests/open10 > > > > Test results comparison on 4.17 versions, > > https://qa-reports.linaro.org/lkft/linux-stable-rc-4.17-oe/tests/ltp-syscalls-tests/creat08 > > https://qa-reports.linaro.org/lkft/linux-stable-rc-4.17-oe/tests/ltp-syscalls-tests/open10 > > > > Bug report link, > > https://bugs.linaro.org/show_bug.cgi?id=3940 > > > > Summary > > ------------------------------------------------------------------------ > > > > kernel: 4.17.7-rc1 > > git repo: > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > git branch: linux-4.17.y > > git commit: bc0bd9e05fa1e213c689620eb4cba825c03dcc4a > > git describe: v4.17.6-68-gbc0bd9e05fa1 > > Test details: > > https://qa-reports.linaro.org/lkft/linux-stable-rc-4.17-oe/build/v4.17.6-68-gbc0bd9e05fa1 > > > > Regressions (compared to build v4.17.6-67-g3b02b1fd1975) > > ------------------------------------------------------------------------ > > > > LTP syscalls failed test cases on all devices, > > > > - creat08 > > - open10 > > > > -- > > Linaro LKFT > > https://lkft.linaro.org > > > > -- > > Mailing list info: https://lists.linux.it/listinfo/ltp > > > -- Dave Chinner dchinner@redhat.com