From: kbuild test robot <lkp@intel.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: kbuild-all@01.org, jdmason@kudzu.us, dave.jiang@intel.com,
allenbh@gmail.com, Sergey.Semin@t-platforms.ru,
linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org,
Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH 2/4] ntb: idt: Add basic hwmon sysfs interface
Date: Tue, 17 Jul 2018 09:28:05 +0800 [thread overview]
Message-ID: <20180717012805.GI10593@intel.com> (raw)
In-Reply-To: <20180714115834.3350-3-fancer.lancer@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3410 bytes --]
Hi Serge,
I love your patch! Yet something to improve:
[auto build test ERROR on ntb/ntb-next]
[also build test ERROR on v4.18-rc4 next-20180713]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Serge-Semin/ntb-idt-Add-hwmon-temperature-sensor-interface/20180714-203042
base: https://github.com/jonmason/ntb ntb-next
config: i386-randconfig-sb0-07142045 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
All errors (new ones prefixed by >>):
drivers/ntb/hw/idt/ntb_hw_idt.o: In function `idt_init_temp':
>> drivers/ntb/hw/idt/ntb_hw_idt.c:2128: undefined reference to `devm_hwmon_device_register_with_groups'
# https://github.com/0day-ci/linux/commit/e5df08844556d4987cb936b26a0423befaf2bfcc
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout e5df08844556d4987cb936b26a0423befaf2bfcc
vim +2128 drivers/ntb/hw/idt/ntb_hw_idt.c
bf2a952d Serge Semin 2017-04-12 2108
e5df0884 Serge Semin 2018-07-14 2109 /*
e5df0884 Serge Semin 2018-07-14 2110 * idt_init_temp() - initialize temperature sensor interface
e5df0884 Serge Semin 2018-07-14 2111 * @ndev: IDT NTB hardware driver descriptor
e5df0884 Serge Semin 2018-07-14 2112 *
e5df0884 Serge Semin 2018-07-14 2113 * Simple sensor initializarion method is responsible for device switching
e5df0884 Serge Semin 2018-07-14 2114 * on and resource management based hwmon interface registration. Note, that
e5df0884 Serge Semin 2018-07-14 2115 * since the device is shared we won't disable it on remove, but leave it
e5df0884 Serge Semin 2018-07-14 2116 * working until the system is powered off.
e5df0884 Serge Semin 2018-07-14 2117 */
e5df0884 Serge Semin 2018-07-14 2118 static void idt_init_temp(struct idt_ntb_dev *ndev)
e5df0884 Serge Semin 2018-07-14 2119 {
e5df0884 Serge Semin 2018-07-14 2120 struct device *hwmon;
e5df0884 Serge Semin 2018-07-14 2121
e5df0884 Serge Semin 2018-07-14 2122 /* Enable sensor if it hasn't been already */
e5df0884 Serge Semin 2018-07-14 2123 idt_sw_write(ndev, IDT_SW_TMPCTL, 0x0);
e5df0884 Serge Semin 2018-07-14 2124
e5df0884 Serge Semin 2018-07-14 2125 /* Initialize hwmon interface fields */
e5df0884 Serge Semin 2018-07-14 2126 mutex_init(&ndev->hwmon_mtx);
e5df0884 Serge Semin 2018-07-14 2127
e5df0884 Serge Semin 2018-07-14 @2128 hwmon = devm_hwmon_device_register_with_groups(&ndev->ntb.pdev->dev,
e5df0884 Serge Semin 2018-07-14 2129 ndev->swcfg->name, ndev, idt_temp_groups);
e5df0884 Serge Semin 2018-07-14 2130 if (IS_ERR(hwmon)) {
e5df0884 Serge Semin 2018-07-14 2131 dev_err(&ndev->ntb.pdev->dev, "Couldn't create hwmon device");
e5df0884 Serge Semin 2018-07-14 2132 return;
e5df0884 Serge Semin 2018-07-14 2133 }
e5df0884 Serge Semin 2018-07-14 2134
e5df0884 Serge Semin 2018-07-14 2135 dev_dbg(&ndev->ntb.pdev->dev, "Temperature HWmon interface registered");
e5df0884 Serge Semin 2018-07-14 2136 }
e5df0884 Serge Semin 2018-07-14 2137
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31948 bytes --]
next prev parent reply other threads:[~2018-07-17 1:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 11:58 [PATCH 0/4] ntb: idt: Add hwmon temperature sensor interface Serge Semin
2018-07-14 11:58 ` [PATCH 1/4] ntb: idt: Alter temperature read method Serge Semin
2018-07-14 11:58 ` [PATCH 2/4] ntb: idt: Add basic hwmon sysfs interface Serge Semin
2018-07-17 1:28 ` kbuild test robot [this message]
2018-07-17 1:28 ` kbuild test robot
2018-07-14 11:58 ` [PATCH 3/4] ntb: idt: Discard temperature sensor IRQ handler Serge Semin
2018-07-14 11:58 ` [PATCH 4/4] ntb: idt: Alter the driver info comments Serge Semin
2018-07-17 9:24 ` [PATCH v2 0/4] ntb: idt: Add hwmon temperature sensor interface Serge Semin
2018-07-17 9:24 ` [PATCH v2 1/4] ntb: idt: Alter temperature read method Serge Semin
2018-07-17 9:24 ` [PATCH v2 2/4] ntb: idt: Add basic hwmon sysfs interface Serge Semin
2018-07-17 9:24 ` [PATCH v2 3/4] ntb: idt: Discard temperature sensor IRQ handler Serge Semin
2018-07-17 9:24 ` [PATCH v2 4/4] ntb: idt: Alter the driver info comments Serge Semin
2018-11-01 14:35 ` [PATCH v2 0/4] ntb: idt: Add hwmon temperature sensor interface Jon Mason
2018-10-31 21:27 ` [PATCH " Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717012805.GI10593@intel.com \
--to=lkp@intel.com \
--cc=Sergey.Semin@t-platforms.ru \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).