From: Tony Lindgren <tony@atomide.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: linux-omap@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ARM: dts: am335x: add am335x-sancloud-bbe board support
Date: Mon, 16 Jul 2018 23:16:40 -0700 [thread overview]
Message-ID: <20180717061640.GX99251@atomide.com> (raw)
In-Reply-To: <1531463123-30340-3-git-send-email-koen@dominion.thruhere.net>
Hi Koen,
Just noticed there should be generic node names here too, see below.
* Koen Kooi <koen@dominion.thruhere.net> [180713 06:28]:
> The "Beaglebone Enhanced" by Sancloud is based on the Beaglebone Black,
> but with the following differences:
>
> * Gigabit capable PHY
> * Extra USB hub, optional i2c control
> * lps3331ap barometer connected over i2c
> * MPU6050 6 axis MEMS accelerometer/gyro connected over i2c
> * 1GiB DDR3 RAM
> * RTL8723 Wifi/Bluetooth connected over USB
> +&i2c0 {
> + lps331ap: lps331ap@5C {
> + compatible = "st,lps331ap-press";
> + st,drdy-int-pin = <1>;
> + reg = <0x5C>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <26 IRQ_TYPE_EDGE_RISING>;
> + };
lps33lap: barometer@5c
> + mpu6050: mpu6050@68 {
> + compatible = "invensense,mpu6050";
> + reg = <0x68>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <2 IRQ_TYPE_EDGE_RISING>;
> + orientation = <0xff 0 0 0 1 0 0 0 0xff>;
> + };
mpu6050: accelerometer@2c
And so on. Please check the lower case hex numbers too as
that's what Linux typically uses.
Thanks,
Tony
next prev parent reply other threads:[~2018-07-17 6:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 6:25 [PATCH v4 0/2] ARM: dts: am3355: add support for the Sancloud Beaglebone Enhanced Koen Kooi
2018-07-13 6:25 ` [PATCH v4 1/2] dt-bindings: Add vendor prefix for Sancloud Koen Kooi
2018-07-13 6:25 ` [PATCH v4 2/2] ARM: dts: am335x: add am335x-sancloud-bbe board support Koen Kooi
2018-07-17 6:16 ` Tony Lindgren [this message]
2018-07-17 6:26 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717061640.GX99251@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=koen@dominion.thruhere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox